Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated routing articles to Symfony 4#8657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yceruto left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
What about promoting thecontroller: key config in YAML format?
javiereguiluz commentedNov 15, 2017
@yceruto that makes a lot of sense to me! Updated. Thanks. |
yceruto left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome! Thanks!
| $collection->add('contact', new Route( | ||
| '/contact', array( | ||
| '_controller' => 'AcmeDemoBundle:Main:contact', | ||
| '_controller' => 'App\Controller\DefaultController::contact', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's minor, and not worth delaying things because it's such a not important format, but in PHP, using the[DefaultController::class, 'contact'] is friendlier.
weaverryan commentedNov 17, 2017
Brilliant! That new controller: key is great! |
Uh oh!
There was an error while loading.Please reload this page.
Thisfixes#8656.