Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated the Workflow articles to Symfony 4#8654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedNov 15, 2017
symfony/recipes#256 has been merged |
workflow/state-machines.rst Outdated
| public function __constructor(Registry $workflows) | ||
| { | ||
| $this->stateMachine = $workflows->get('pull_request'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would not do that inside the constructor. You'll never know when your service is initialized and if the registry is ready at this point which could lead to undesired side effects.
workflow/usage.rst Outdated
| { | ||
| public function edit(Registry $workflows) | ||
| { | ||
| $post = new \App\Entity\BlogPost(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would add a use statement for the class instead of using the FQCN here.
workflow/usage.rst Outdated
| // ... | ||
| } | ||
| // See all the available transition for the post in the current state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
transitions
workflow/usage.rst Outdated
| * ``workflow.[workflow name].announce.[transition name]`` | ||
| Here is an example how to enable logging for every time a the "blog_publishing" workflow leaves a place:: | ||
| Here is an example how to enable logging for every time the ``blog_publishing`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[...] an example of [...]
…, weaverryan)This PR was merged into the master branch.Discussion----------Updated the Workflow articles to Symfony 4The new file config paths are pending of this:symfony/recipes#256Commits-------70dda7c adding usef9bb412 minor tweaks8c540ce Removed an unneeded comment (Flex now includes Console by default)5088d0e Lots of fixes0261149 Fixed a typo9690dfd Updated the Workflow articles to Symfony 4
The new file config paths are pending of this:symfony/recipes#256