Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Made two more configuration guides flex-ready#8647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6e82d96 tofff3c38Compareconfiguration/environments.rst Outdated
| <importresource="config.xml" /> | ||
| </imports> | ||
| // ... | ||
| $confDir = dirname(__DIR__).'/config'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$this->getProjectDir()? in line with the latest changessymfony/recipes#244.
configuration/environments.rst Outdated
| // app/config/config_benchmark.php | ||
| $loader->import('config_prod.php'); | ||
| // config/benchmark/web_profiler.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
config/packages/benchmark/web_profiler.php?
| # .env | ||
| DATABASE_URL="mysql://db_user:db_password@127.0.0.1:3306/db_name?charset=utf8mb4&serverVersion=5.7" | ||
| This variable is referenced in the serivce container configuration using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typoservice
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
configuration/environments.rst Outdated
| * Loaded in all environments, ``config/packages/framework.yaml`` configures the | ||
| framework with some ``secret`` setting; | ||
| * In the **prod** environment, nothing extra will be set as there is no | ||
| ``config/packages/prod`` directory; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
config/packages/prod ->config/packages/prod/
fff3c38 to70066bfCompare70066bf toad4b3a2Comparewouterj commentedNov 14, 2017
Thanks@javiereguiluz@yceruto, fixed all comments you made! |
This PR was merged into the master branch.Discussion----------Made two more configuration guides flex-readyCommits-------ad4b3a2 Made two configuration sub guides flex-ready
weaverryan commentedNov 21, 2017
…iluz, weaverryan)This PR was merged into the 4.0 branch.Discussion----------Updated the best practice article about configThis was the only remaining article to be updated in "Best Practices".Related to this:* The main config.rst is being updated in ~~#8588~~* Some config/* articles are being updated in ~~#8647~~.* I'm going to update the rest of config/* articles.Commits-------175a4e8 minor tweaksb973f0c Updated the best practice article about config
No description provided.