Add new translations config path#8634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

yceruto wants to merge1 commit intosymfony:masterfromyceruto:translations_path

Closed

Add new translations config path#8634

yceruto wants to merge1 commit intosymfony:masterfromyceruto:translations_path

Conversation

Copy link

Member

yceruto commentedNov 13, 2017•
edited
Loading

Seesymfony/symfony#24860 andsymfony/symfony#25065

carsonbot added the Status: Needs Review label

Nov 13, 2017

xabbuh added the On hold label

Nov 13, 2017

yceruto mentioned this pull request

Nov 21, 2017

[FrameworkBundle] Update translation commands to work with default pathssymfony/symfony#25065

Merged

1 task

fabpot added a commit to symfony/symfony that referenced this pull request

Nov 23, 2017

bug#25065[FrameworkBundle] Update translation commands to work with…

ec379e1

… default paths (yceruto)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Update translation commands to work with default paths| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25062| License       | MIT| Doc PR        |symfony/symfony-docs#8634This should make translation commands (debug & update) work with `translator.default_path` and `twig.default_path` directories (introduced here in 3.4) and their overridden paths if available.Would be great to include also the custom paths mapping by the user, either `translator.paths` as `twig.paths`, but I'm not sure about the right way and probably it should be implemented on another branch.TODO- [x]  Add some tests.Commits-------dc72866 Update translation commands to work with default paths

symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request

Nov 23, 2017

bug #25065 [FrameworkBundle] Update translation commands to work with…

5354d3b

… default paths (yceruto)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Update translation commands to work with default paths| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony/symfony#25062| License       | MIT| Doc PR        |symfony/symfony-docs#8634This should make translation commands (debug & update) work with `translator.default_path` and `twig.default_path` directories (introduced here in 3.4) and their overridden paths if available.Would be great to include also the custom paths mapping by the user, either `translator.paths` as `twig.paths`, but I'm not sure about the right way and probably it should be implemented on another branch.TODO- [x]  Add some tests.Commits-------dc7286625b Update translation commands to work with default paths