Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated the bundle configuration articles to Symfony 4#8620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're on a great update streak!
bundles/configuration.rst Outdated
| ..sidebar::Using Parameters to Configure your Bundle | ||
| If you don't have plans to share your bundle between projects, it doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Then don't create a bundle...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Haha, yea, I agree with Wouter. We can still say this is optional, of course, but if you're reading this, then youdo want to share your bundle between projects :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are completely right! This only made sense in the past, where bundles could be non-shareable ... but that's no longer the case. Removed the entire sidebar!
bundles/configuration.rst Outdated
| ..sidebar::Using Parameters to Configure your Bundle | ||
| If you don't have plans to share your bundle between projects, it doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Haha, yea, I agree with Wouter. We can still say this is optional, of course, but if you're reading this, then youdo want to share your bundle between projects :)
weaverryan commentedNov 12, 2017
One minor comment + fix the conflict. Then we can merge! |
25ebe7c to1479c71Comparexabbuh commentedNov 14, 2017
Thank you Javier. |
No description provided.