Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated Bundles Best Practices for Symfony 4#8616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bundles/best_practices.rst Outdated
| Installation | ||
| ------------ | ||
| Bundles must define a `Symfony Flex recipe`_ to automate their integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems way to strict and unwanted in my opinion. You only need to add a flex recipe if you need logic to be executed when installing your bundle. Otherwise,type: symfony-bundle is enough to have auto registration.
We shouldn't want to have many empty manifests in the contrib repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree. How about:
Bundles should set ``"type": "symfony-bundle"`` in their ``composer.json`` file. With this,`Symfony Flex`_ will be able to automatically enable your bundle when it's installed.If your bundle requires any setup (e.g. configuration, new files, changes to `.gitignore`, etc),then you should create a `Flex recipe`_.
bundles/best_practices.rst Outdated
| Open a command console, enter your project directory and execute: | ||
| .. code-block:: terminal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We have to usebash here, as terminal is a special Symfony docs only lexer.
bundles/best_practices.rst Outdated
| Installation | ||
| ------------ | ||
| Bundles must define a `Symfony Flex recipe`_ to automate their integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree. How about:
Bundles should set ``"type": "symfony-bundle"`` in their ``composer.json`` file. With this,`Symfony Flex`_ will be able to automatically enable your bundle when it's installed.If your bundle requires any setup (e.g. configuration, new files, changes to `.gitignore`, etc),then you should create a `Flex recipe`_.
No description provided.