Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix paths in testing/bootstrap.rst#8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
boedah wants to merge1 commit intosymfony:3.3fromboedah:patch-1
Closed

Conversation

@boedah
Copy link
Contributor

  • comment saidapp/tests.bootstrap.php but xml referenced the root
  • path to autoload was wrong
  • Symfony console now is in/bin

* comment said `app/tests.bootstrap.php` but xml referenced the root* path to autoload was wrong* Symfony console now is in `/bin`
@yceruto
Copy link
Member

yceruto commentedNov 8, 2017•
edited
Loading

Probably this article should be refactored entirely to adapt to 3.3 structurehttps://github.com/symfony/symfony-standard/tree/3.3

For example, thistest.boostrap.php file could live insidetests/ directory and would be namedbootstrap.php. Also I'm not sure whether theif statement is really necessary or not.

wouterj added a commit that referenced this pull requestNov 12, 2017
This PR was merged into the 3.3 branch.Discussion----------fix paths in testing/bootstrap.rst* comment said `app/tests.bootstrap.php` but xml referenced the root* path to autoload was wrong* Symfony console now is in `/bin`Commits-------e075514 fix paths
@wouterj
Copy link
Member

Good work@boedah! This article was indeed not completely correct...

I've merged your PR, and then changed stuff a little more ina7d8d97 . The main change here is moving this bootstrap file totests/bootstrap.php, which I think is a nicer location.

Thanks!

weaverryan added a commit that referenced this pull requestNov 12, 2017
* 3.3:  Added Best Practice guideline for partials/include  Backporting#8600  [#8605] Updated the article a little more, using the tests/ directory.  fix paths  Move `schema_filter` option to the correct place  Fix typo in "advanced ACL concepts"  Add special Abstract prefix not usage for PHPUnit test cases
weaverryan added a commit that referenced this pull requestNov 12, 2017
* 3.4:  Added Best Practice guideline for partials/include  Backporting#8600  [#8605] Updated the article a little more, using the tests/ directory.  fix paths  Move `schema_filter` option to the correct place  Fix typo in "advanced ACL concepts"  Add special Abstract prefix not usage for PHPUnit test cases
@boedahboedah deleted the patch-1 branchNovember 13, 2017 11:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boedah@yceruto@wouterj
[8]ページ先頭
©2009-2025 Movatter.jp