Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Reworded the introduction of event listeners article#8603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xabbuh approved these changesNov 8, 2017
weaverryan requested changesNov 10, 2017
| Symfony triggers several:doc:`events related to the kernel</reference/events>` | ||
| while processing an HTTP Request, third-party bundles and libraries also trigger | ||
| lots of events and your own application can trigger:doc:`custom events | ||
| </components/event_dispatcher>`. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like this... but this sentence is too long. I think we need a period afterHTTP Request. And then maybe the next sentence needs a little bit of work.
weaverryan added a commit that referenced this pull requestNov 10, 2017
…iereguiluz)This PR was merged into the 2.7 branch.Discussion----------Reworded the introduction of event listeners articleWe have an article explaining the kernel events, so there's no need to link to the KernelEvents class source code.Commits-------be2f7ef Reworded the introduction of event listeners article
Member
weaverryan commentedNov 10, 2017
I just re-worded it to save time - see sha:8c689ec Feel free to re-reword if it's not quite perfect :). |
weaverryan added a commit that referenced this pull requestNov 10, 2017
* 2.7: parameter name typo [#8603] Rewording [BrowserKit] Updated Project URI of Goutte Changed the title of a Doctrine article to avoid confusion Reworded the introduction of event listeners article
weaverryan added a commit that referenced this pull requestNov 10, 2017
* 2.8: parameter name typo [#8603] Rewording [BrowserKit] Updated Project URI of Goutte Changed the title of a Doctrine article to avoid confusion Reworded the introduction of event listeners article
weaverryan added a commit that referenced this pull requestNov 10, 2017
* 3.3: parameter name typo [#8603] Rewording [BrowserKit] Updated Project URI of Goutte Update index.rst Update redirection_map Delete progresshelper.rst Minor reword in autowiring introduction Changed the title of a Doctrine article to avoid confusion Reworded the introduction of event listeners article Little typo error Update flex.rst Asset Component and absolute paths Grouped assets example
weaverryan added a commit that referenced this pull requestNov 10, 2017
* 3.4: parameter name typo [#8603] Rewording [BrowserKit] Updated Project URI of Goutte [#8495] Minor tweaks Update index.rst Update redirection_map Delete progresshelper.rst Minor reword in autowiring introduction Changed the title of a Doctrine article to avoid confusion Reworded the introduction of event listeners article Little typo error Update flex.rst Asset Component and absolute paths Grouped assets example Minor reword Mentioned the new case-sensitivity of container parameters Document disabling the usage of globally defined form themes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an article explaining the kernel events, so there's no need to link to the KernelEvents class source code.