Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add special Abstract prefix not usage for PHPUnit test cases#8600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
contributing/code/standards.rst Outdated
| * Use namespaces for all classes; | ||
| * Prefix abstract classes with ``Abstract``. Please note some early Symfony classes | ||
| * Prefixallabstract classes with ``Abstract`` excepting PHPUnit ``*TestCase``. Please note some early Symfony classes |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"except"
contributing/code/standards.rst Outdated
| * Use namespaces for all classes; | ||
| * Prefix abstract classes with ``Abstract``. Please note some early Symfony classes | ||
| * Prefixallabstract classes with ``Abstract`` excepting PHPUnit ``*TestCase``. Please note some early Symfony classes |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please comply with the sf docs standards:
wouterj approved these changesNov 12, 2017
Member
weaverryan commentedNov 12, 2017
Thanks@soullivaneuh! |
weaverryan added a commit that referenced this pull requestNov 12, 2017
…ses (Soullivaneuh)This PR was merged into the 3.3 branch.Discussion----------Add special Abstract prefix not usage for PHPUnit test casesAs we can see here:You are not using the `Abstract` prefix at all for the test cases.I assume this is to follow PHPUnit conventions on this part?In this case, the coding standard may be more accurate about this.Commits-------f4d122a Add special Abstract prefix not usage for PHPUnit test cases
Member
weaverryan commentedNov 12, 2017
Just a note: I forgot to switch the branch to 2.7 on merge, but backported it manually. |
weaverryan added a commit that referenced this pull requestNov 12, 2017
* 2.7: Added Best Practice guideline for partials/include Backporting#8600 Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts"
weaverryan added a commit that referenced this pull requestNov 12, 2017
* 2.8: Added Best Practice guideline for partials/include Backporting#8600 Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts"
weaverryan added a commit that referenced this pull requestNov 12, 2017
* 3.3: Added Best Practice guideline for partials/include Backporting#8600 [#8605] Updated the article a little more, using the tests/ directory. fix paths Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts" Add special Abstract prefix not usage for PHPUnit test cases
weaverryan added a commit that referenced this pull requestNov 12, 2017
* 3.4: Added Best Practice guideline for partials/include Backporting#8600 [#8605] Updated the article a little more, using the tests/ directory. fix paths Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts" Add special Abstract prefix not usage for PHPUnit test cases
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As we can see here:
You are not using the
Abstractprefix at all for the test cases.I assume this is to follow PHPUnit conventions on this part?
In this case, the coding standard may be more accurate about this.