Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Migrating Best Practices topics to Symfony Flex structure#8579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| providers: | ||
| database_users: | ||
| entity:{ class:AppBundle:User, property: username } | ||
| entity:{ class:App:User, property: username } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This could beApp\Entity\User ... but it may be better to do that change in all docs in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yea, I agree. The namespace is now small enough that this slightly longer format is worth it because it's more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've actually just made this change, as this is the only spot in the docs where this appears (there are still many references ofAppBundle:, but this is the only one that isApp:). As we migrate away fromAppBundle, we can also change to not use the shortcut.
…re (yceruto)This PR was merged into the master branch.Discussion----------Migrating Best Practices topics to Symfony Flex structurePending files for other PR:* configuration.rst* creating-the-project.rst* i18n.rst* templates.rstCommits-------176bbdf [Best Practices] More changes of Symfony Flex structure
Uh oh!
There was an error while loading.Please reload this page.
Pending files for other PR: