Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Docs re-org and removal of small sections#8537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* new-request-re-org: Moving PSR7 into components Removing mime type article and simply moving into reference config TODO - refactoring request article Moving reverse proxies
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like this a lot. All proposed changes make a lot of sense to me. Thanks!
I'll do the related changes on symfony.com.
| request | ||
| ~~~~~~~ | ||
| formats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we include here the configuration example of the originalrequest/mime_type.rst article?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good idea - done!
weaverryan commentedOct 24, 2017
@javiereguiluz I have the same question here as#8538
Will that be automatic? |
javiereguiluz commentedOct 24, 2017
It's not automatic, but I've removed them in symfony.com repo, so they'll disappear after the next deployment. This is how it'd look:
|
weaverryan commentedOct 24, 2017
Thank you@javiereguiluz! It sounds like we should wait until that deploy, correct? |
This PR was squashed before being merged into the 2.7 branch (closes#8537).Discussion----------Docs re-org and removal of small sectionsHi guys!I'd like to have less "Guides" on the left. Some of them only have 1 article or (imo) are not something that's helpful for the user. In this PR, i:1) Move Assetic out of the top-level and under `frontend`.2) Removed/moved the Expressions guide3) Removed/moved the "Request" guidesOn Symfony.com, we would need to remove the "Assetic", "Expressions" and "Request" guides. All of this content still exists, just somewhere else.The bigger goal is - through a number of PR's - to reduce the number of "guides" links and make sure we have the best links that people will be looking for.Thanks!Commits-------678a921 Docs re-org and removal of small sections
Hi guys!
I'd like to have less "Guides" on the left. Some of them only have 1 article or (imo) are not something that's helpful for the user. In this PR, i:
frontend.On Symfony.com, we would need to remove the "Assetic", "Expressions" and "Request" guides. All of this content still exists, just somewhere else.
The bigger goal is - through a number of PR's - to reduce the number of "guides" links and make sure we have the best links that people will be looking for.
Thanks!