Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Form] Document disabling the usage of globally defined form themes#8495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 task
fabpot added a commit to symfony/symfony that referenced this pull requestOct 13, 2017
…efault themes when rendering a form (emodric)This PR was merged into the 3.4 branch.Discussion----------[Form] [TwigBridge] Added option to disable usage of default themes when rendering a form| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR |symfony/symfony-docs#8495This adds a possibility to use `only` keyword in `form_theme` tag to disable usage of globally defined form themes, e.g.`{% form_theme form with ['common.html.twig', 'form/fields.html.twig'] only %}`Otherwise, in order to completely control the rendering of the forms (for example in custom admin interfaces), one would need to use a form theme which has all the possible twig blocks defined to prevent globally defined themes to interfere with the rendering.`only` keyword is already used when including a Twig template to transfer only the variables which are explicitly defined in the `include` tag, so it seemed natural to use it here too.This, of course, means that the user will need to manually `use` all of the templates that are required to render the form, including `form_div_layout.html.twig`This issue is described in details over at Symfony Demo repo:symfony/demo#515TODO:- [x] submit changes to the documentationCommits-------e0681f9 [Form] [TwigBridge] Added option to disable usage of default themes when rendering a form
ContributorAuthor
emodric commentedOct 16, 2017
@javiereguiluz@xabbuh This is ready for review since the related PR in Symfony is merged now :) |
javiereguiluz approved these changesOct 29, 2017
weaverryan added a commit that referenced this pull requestNov 10, 2017
… form themes (emodric, javiereguiluz)This PR was merged into the 3.4 branch.Discussion----------[Form] Document disabling the usage of globally defined form themesThis PR documents the option to disable the usage of globally defined form themes. This is suggested as a feature insymfony/symfony#22610 (reviewed, but not yet merged)Commits-------14ef7ae Minor reword8d45f83 Document disabling the usage of globally defined form themes
Member
weaverryan commentedNov 10, 2017
Thanks@emodric! |
weaverryan added a commit that referenced this pull requestNov 10, 2017
* 3.4: parameter name typo [#8603] Rewording [BrowserKit] Updated Project URI of Goutte [#8495] Minor tweaks Update index.rst Update redirection_map Delete progresshelper.rst Minor reword in autowiring introduction Changed the title of a Doctrine article to avoid confusion Reworded the introduction of event listeners article Little typo error Update flex.rst Asset Component and absolute paths Grouped assets example Minor reword Mentioned the new case-sensitivity of container parameters Document disabling the usage of globally defined form themes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the option to disable the usage of globally defined form themes. This is suggested as a feature insymfony/symfony#22610 (reviewed, but not yet merged)