Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Html5 Email Validation#8487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:masterfromPurpleBooth:optional-email-filter
Dec 22, 2017
Merged

[Validator] Html5 Email Validation#8487

xabbuh merged 1 commit intosymfony:masterfromPurpleBooth:optional-email-filter
Dec 22, 2017

Conversation

@PurpleBooth
Copy link
Contributor

Add documentation about the new mode parameter. Adds descriptions for
the 'loose', 'strict', and 'html5' options.

Relates tosymfony/symfony#24442

@xabbuhxabbuh added this to the3.4 milestoneOct 6, 2017
fabpot added a commit to symfony/symfony that referenced this pull requestDec 11, 2017
This PR was merged into the 4.1-dev branch.Discussion----------[Validator] Html5 Email ValidationCurrently we only support a very loose validation. There is now astandard HTML5 element with matching regex. This will add the abilityto set a `mode` on the email validator. The mode will change thevalidation that is applied to the field as a whole.These modes are:* loose: The pattern from previous Symfony versions (default)* strict: Strictly matching the RFC* html5: The regex used for the HTML5 ElementDeprecates the `strict=true` parameter in favour of `mode='strict'`| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#21531| License       | MIT| Doc PR        |symfony/symfony-docs#8487<!--- Bug fixes must be submitted against the lowest branch where they apply  (lowest branches are regularly merged to upper ones so they get the fixes too).- Features and deprecations must be submitted against the 3.4,  legacy code removals go to the master branch.- Please fill in this template according to the PR you're about to submit.- Replace this comment by a description of what your PR is solving.-->Commits-------cf04108 [Validator] Html5 Email Validation
@PurpleBoothPurpleBooth changed the base branch from3.4 tomasterDecember 11, 2017 20:43
@PurpleBooth
Copy link
ContributorAuthor

PurpleBooth commentedDec 11, 2017
edited
Loading

I've rebased this off master, as eventually the PR went into the 4.1 branch (which is currently master).

I'd love get this reviewed now that that's merged in.

@xabbuhxabbuh removed the On hold labelDec 12, 2017
@xabbuhxabbuh modified the milestones:3.4,4.1Dec 12, 2017
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks great. I have just left a few minor comments. Thanks for creating the feature and writing the documentation for it.

Add documentation about the new mode parameter. Adds descriptions forthe 'loose', 'strict', and 'html5' options.
@xabbuh
Copy link
Member

Thank you@PurpleBooth.

PurpleBooth reacted with hooray emoji

@xabbuhxabbuh merged commit07d4bf9 intosymfony:masterDec 22, 2017
xabbuh added a commit that referenced this pull requestDec 22, 2017
This PR was merged into the master branch.Discussion----------[Validator] Html5 Email ValidationAdd documentation about the new mode parameter. Adds descriptions forthe 'loose', 'strict', and 'html5' options.Relates tosymfony/symfony#24442Commits-------07d4bf9 [Validator] Html5 Email Validation
@PurpleBoothPurpleBooth deleted the optional-email-filter branchDecember 22, 2017 11:14
| Applies to|:ref:`property or method<validation-property-target>`|
+----------------+---------------------------------------------------------------------+
| Options| - `strict`_|
| Options| - `mode`_|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't thestrict option have been annotated as "deprecated in Symfony 4.1" rather than completely replaced?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@guilliamxavierguilliamxavierguilliamxavier left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@PurpleBooth@xabbuh@guilliamxavier@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp