Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updates to Platform.sh deploy instructions#8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
pjcdawkins wants to merge1 commit intosymfony:3.3frompjcdawkins:patch-1

Conversation

@pjcdawkins
Copy link

@pjcdawkinspjcdawkins commentedSep 15, 2017
edited
Loading

  • Update example PHP version from 5.6 to 7.1
  • Files in.platform are now required
  • Endpoint namephp is better written ashttp
  • Build flavorsymfony is better written ascomposer
  • Rename database frommysql tomydatabase to separate it clearly from the service type
  • Theweb section should now uselocations
  • Use SSL by default (certificate provisioning and 'http://' redirects are automatic)

There are probably additional improvements that can be made, referring to the Platform.shdocumentation and to the work that has been done inhttps://github.com/platformsh/platformsh-example-symfony/

* Update example PHP version from 5.6 to 7.1* Files in `.platform` are now required* Endpoint name `php` is better written as `http`* Build flavor `symfony` is better written as `composer`* Rename database from `mysql` to `mydatabase` to separate it clearly from the service type* The `web` section should now use `locations`
type:php:7.1
build:
flavor:symfony
flavor:composer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why do you change this?symfony is correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I read somewhere thatcomposer is the new and recommended type for all PHP. Their Symfony template doc use that too:https://docs.platform.sh/frameworks/symfony.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

good to know, thank you@javiereguiluz 👍

type:upstream
# the first part should be your project name
upstream:'myphpproject:php'
upstream:'myphpproject:http'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should be:

'https://{default}/':type:upstreamupstream:"myphpproject:http"'https://www.{default}/':type:redirectto:"https://{default}/"

HeahDude reacted with thumbs up emoji
@OskarStark
Copy link
Contributor

Refs#8483

bin/console --env=prod cache:clear
For best practices, you shouldalso add a ``.platform`` folder at the root of
Youalso need add a ``.platform`` folder at the root of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

to add

OskarStark reacted with thumbs up emoji
@javiereguiluz
Copy link
Member

@pjcdawkins thanks for this contribution, but sadly we must close this pull request without merging it. Why? Because in#8721 we decided to remove all these articles explaining how to deploy to third-party services. We now simply link to the articles published by those services. Thanks for understanding it.

pjcdawkins reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@OskarStarkOskarStarkOskarStark requested changes

+1 more reviewer

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pjcdawkins@OskarStark@javiereguiluz@HeahDude

[8]ページ先頭

©2009-2025 Movatter.jp