Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Reworded the built-in web server articles for Symfony 3.3#8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
javiereguiluz wants to merge3 commits intosymfony:3.3fromjaviereguiluz:fix_8270

Conversation

@javiereguiluz
Copy link
Member

Thisfixes#8270.

The current scenario for Symfony 3.3 is the worst possible: we don't have the web server by default (like in 3.2) ... and it's not easy to install it (like in 3.3+Flex or 4.0). That's why I propose to add a link in the mainsetup.rst article to the full explanation about installing and enabling the bundle.

In 4.0, we can remove that link and simply say: runsymfony require web-server and then, execute./bin/console server:run.


First, execute this command:

..terminal::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

missingcode-block

$bundles = array(
// ...

if (in_array($this->getEnvironment(), array('dev', 'test'))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if ('dev' === $this->getEnvironment()) { is enough.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done! Thanks.

@xabbuh
Copy link
Member

Thank you Javier.

xabbuh added a commit that referenced this pull requestSep 3, 2017
… (javiereguiluz)This PR was squashed before being merged into the 3.3 branch (closes#8273).Discussion----------Reworded the built-in web server articles for Symfony 3.3Thisfixes#8270.The current scenario for Symfony 3.3 is the worst possible: we don't have the web server by default (like in 3.2) ... and it's not easy to install it (like in 3.3+Flex or 4.0). That's why I propose to add a link in the main `setup.rst` article to the full explanation about installing and enabling the bundle.In 4.0, we can remove that link and simply say: run `symfony require web-server` and then, execute `./bin/console server:run`.Commits-------0cd417b Reworded the built-in web server articles for Symfony 3.3
xabbuh added a commit that referenced this pull requestSep 3, 2017
xabbuh added a commit that referenced this pull requestSep 3, 2017
@xabbuhxabbuh closed thisSep 3, 2017
xabbuh added a commit that referenced this pull requestSep 3, 2017
* 3.3: (40 commits)  [#8273] fix bundle registration code  [#8273] minor rewording  Reworded the built-in web server articles for Symfony 3.3  fix diff code block highlighting  [#8231] fix reStructuredText syntax  Specified import order of config files  [#7981] revert some changes  Update upload_file.rst  Update usage.rst  Update doctrine.rst  Update usage.rst  [#8260] add missing redirection map entry  Delete use_virtuals_forms.rst  Added a missing redirection  Update validation_group_service_resolver.rst  Update redirection_map  Update button_based_validation.rst  Delete group_service_resolver.rst  Create validation_group_service_resolver.rst  [#8290] fix minor typo  ...
xabbuh added a commit that referenced this pull requestSep 3, 2017
* 3.4: (42 commits)  [#8273] fix bundle registration code  [#8273] minor rewording  Reworded the built-in web server articles for Symfony 3.3  fix diff code block highlighting  [#8269] minor rewording  [Console] Commands auto-registration is deprecated  [#8231] fix reStructuredText syntax  Specified import order of config files  [#7981] revert some changes  Update upload_file.rst  Update usage.rst  Update doctrine.rst  Update usage.rst  [#8260] add missing redirection map entry  Delete use_virtuals_forms.rst  Added a missing redirection  Update validation_group_service_resolver.rst  Update redirection_map  Update button_based_validation.rst  Delete group_service_resolver.rst  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

+1 more reviewer

@HeahDudeHeahDudeHeahDude left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javiereguiluz@xabbuh@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp