Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Serializer] Document the new DateIntervalNormalizer normalizer#8267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ogizanagi added a commit to symfony/symfony that referenced this pull requestSep 15, 2017
…lizer (Lctrs)This PR was squashed before being merged into the 3.4 branch (closes#23747).Discussion----------[Serializer][FrameworkBundle] Add a DateInterval normalizer| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#8267Could be useful for API needing to submit a duration.Most code have been adapted from@MisatoTremor's DateInterval form type. Credits to him.Commits-------6185cb1 [Serializer][FrameworkBundle] Add a DateInterval normalizer
symfony-splitter pushed a commit to symfony/serializer that referenced this pull requestSep 15, 2017
…lizer (Lctrs)This PR was squashed before being merged into the 3.4 branch (closes #23747).Discussion----------[Serializer][FrameworkBundle] Add a DateInterval normalizer| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#8267Could be useful for API needing to submit a duration.Most code have been adapted from@MisatoTremor's DateInterval form type. Credits to him.Commits-------6185cb1991 [Serializer][FrameworkBundle] Add a DateInterval normalizer
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestSep 15, 2017
…lizer (Lctrs)This PR was squashed before being merged into the 3.4 branch (closes #23747).Discussion----------[Serializer][FrameworkBundle] Add a DateInterval normalizer| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#8267Could be useful for API needing to submit a duration.Most code have been adapted from@MisatoTremor's DateInterval form type. Credits to him.Commits-------6185cb1991 [Serializer][FrameworkBundle] Add a DateInterval normalizer
ContributorAuthor
Lctrs commentedSep 15, 2017
@xabbuh It has been merged. Is there any changes that need to be made to this PR ? |
xabbuh approved these changesSep 18, 2017
Member
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 looks good to me
Member
xabbuh commentedSep 22, 2017
Thank you@Lctrs. |
xabbuh added a commit that referenced this pull requestSep 22, 2017
…alizer (Lctrs)This PR was squashed before being merged into the 3.4 branch (closes#8267).Discussion----------[Serializer] Document the new DateIntervalNormalizer normalizerWaiting forsymfony/symfony#23747 to be merged.Commits-------9784714 [Serializer] Document the new DateIntervalNormalizer normalizer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting forsymfony/symfony#23747 to be merged.