Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed logger processor example#8226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:2.7fromHeahDude:fix/log-processing
Sep 3, 2017

Conversation

@HeahDude
Copy link
Contributor

Fixes#7897.

@HeahDudeHeahDude added the bug labelJul 25, 2017
@HeahDudeHeahDude added this to the2.7 milestoneJul 25, 2017
monolog.processor.session_request:
class:AppBundle\SessionRequestProcessor
app.logger.session_request_processor:
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should be an FQCN from 3.3

$container
->register('monolog.processor.session_request', SessionRequestProcessor::class)
->register('app.logger.session_request_processor', SessionRequestProcessor::class)
->addArgument(new Reference('session'))
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

'session' should beSessionInterface::class from 3.3

$this->sessionId = substr($this->session->getId(), 0, 8) ?: '????????';
}
$record['extra']['token'] = $this->sessionId.'-'.substr(uniqid(), -8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we should passtrue as the second argument touniqid()

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Right, done!

@xabbuh
Copy link
Member

Thank you@HeahDude.

@xabbuhxabbuh merged commit24ddb64 intosymfony:2.7Sep 3, 2017
xabbuh added a commit that referenced this pull requestSep 3, 2017
This PR was merged into the 2.7 branch.Discussion----------Fixed logger processor exampleFixes#7897.Commits-------24ddb64 Fixed logger processor example
@HeahDudeHeahDude deleted the fix/log-processing branchSeptember 3, 2017 11:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@HeahDude@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp