Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
SiteUpdateManager should return $happyMessage and not the mailer service#8224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $this->mailer->send($message); | ||
| return $message; | ||
| return $happyMessage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure this method should return anything. The controller should use a custom alert instead of this returned value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree with you that this is not an ideal example. I have merged this PR nonetheless as it would make the code at least work as it was supposed to be initially. We should handle the rest in a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see#8339
xabbuh commentedSep 3, 2017
Thank you@revollat. |
… mailer service (revollat)This PR was merged into the 3.3 branch.Discussion----------SiteUpdateManager should return $happyMessage and not the mailer serviceCommits-------e42435c SiteUpdateManager should return $happyMessage and not the mailer service
This PR was merged into the 3.3 branch.Discussion----------[DI] fix flash message generationsee#8224 (comment)Commits-------cba0478 Refactored the codecdcb5c8 fix flash message generation
No description provided.