Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Workflow] Document the new transition completed event#8213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
lyrixx added a commit to symfony/symfony that referenced this pull requestAug 7, 2017
This PR was merged into the 3.4 branch.Discussion----------[Workflow] Add transition completed event| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#8213---Because the "entered" event is the only event dispatched after the new marking is applied, and publish's an event upon entering into a "Place" (as opposed to completing a transition), it is not sufficient for a lot of use cases and is causing bugs.Example:Enabled Transitions:1. A -> B2. B -> C3. C -> BTransition 1 and transition 3, will dispatch an "entered" event on Place B, forcing post transition behaviour to be the same for both transition 1 and 3.A user might need different behaviour depending on the transition, rather the the destination.A concrete use case would be when applying an "undo" transition to a subject. One may or may not want to re-trigger all the events associated with the original transition to that Place.I propose adding a "completed" event (ie. Transition completed) in addition to the entered event.Commits-------c254cac [Workflow] Added an transition completed event
Member
javiereguiluz commentedJan 10, 2018
@izzyp thanks for adding these docs and congrats on your first Symfony Docs contribution! |
javiereguiluz added a commit that referenced this pull requestJan 10, 2018
…zzyp)This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes#8213).Discussion----------[Workflow] Document the new transition completed eventas per PR -symfony/symfony#22587Commits-------b8249ab [Workflow] Document the new transition completed event
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per PR -symfony/symfony#22587