Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added a note about container parameters and env vars#8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@javiereguiluz
Copy link
Member

I know that the "note" mentions the Symfony Framework and this is the component article ... but this note should go to the article mentioned in#7386, which sadly doesn't exist yet.

@javiereguiluz
Copy link
MemberAuthor

In this PR I also propose to highlight the.env files withshell instead ofbash. The reason is thatbash is wrapped with a fake console illustration, and that's wrong in this case.

Before

before

After

after

@fabpot
Copy link
Member

I don't understand this change. What's the solution? Just saying it does not work does not help our users. I would really prefer to fix this in Symfony instead. /cc@nicolas-grekas

@javiereguiluz
Copy link
MemberAuthor

There's been a misunderstandig then. Reading this note I thought you didn't want to add this feature to Dotenv:

PHP has a lot of different implementations of this "pattern". This
implementation's goal is to replicate whatsource .env would do. It
tries to be as similar as possible with the standard shell's behavior (so
no value validation for instance).

@fabpot
Copy link
Member

This talks about validation. Here, we are talking about container parameter replacement, which can work for both regular env vars and ones coming from a .env file.

@nicolas-grekas
Copy link
Member

This doesn't relate to Dotenv specifically to me: parameters are not resolved into environment vars, wherever it comes from. Or did I miss something?

javiereguiluz and yceruto reacted with thumbs up emoji

@fabpot
Copy link
Member

Indeed, the question is "do we want to resolve parameters for all env vars"?

javiereguiluz and yceruto reacted with thumbs up emoji

@fabpot
Copy link
Member

I'm closing this PR as this can be fixed thanks tosymfony/symfony#23901

@fabpotfabpot closed thisSep 11, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javiereguiluz@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp