Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add TokenProcessor#8156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add TokenProcessor#8156
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@maidmaid thanks for this contribution!
We usually explain a new feature and then add the versionadded mentioning when it was added ... but in this case, the versionadded directive tries to explain the feature and show when it was added. I think it's missing some context or explanation.
maidmaid commentedJul 16, 2017
How to do? Add a new |
javiereguiluz commentedJul 16, 2017
@maidmaid I don't know exactly how to do it. I'm going to think about this, but maybe@xabbuh has some ideas too. An example of what I wanted to explain:https://github.com/symfony/symfony-docs/pull/8146/files In that PR we explain the new feature very briefly and then we say that it's new in Symfony 3.4. |
xabbuh commentedJul 18, 2017
I think the best solution would be to have a paragraph explaining how to enable this processor and then add a |
HeahDude commentedJul 29, 2017
Agreed with@xabbuh. |
nicolas-grekas commentedJul 2, 2018
ping@maidmaid :) |
This PR was merged into the 3.4 branch.Discussion----------Adds documentation for monolog processors.Adds both a short description for existing processors as well as a note for the newly added TokenProcessor added in 3.4. I tried not to interfere with#10244 as this introduces documentation for more processors added in 4.3, so that PR hopefully can build on this one.Replaces#8156EUFOSSACommits-------67f8c2c Adds documentation for monolog processors.
cfsymfony/symfony#21086