symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Stop using the deprecated "serializer.mapping.cache.apc" service#8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

javiereguiluz wants to merge2 commits intosymfony:3.2fromjaviereguiluz:fix_7282

Closed

Stop using the deprecated "serializer.mapping.cache.apc" service#8133

javiereguiluz wants to merge2 commits intosymfony:3.2fromjaviereguiluz:fix_7282

Conversation

Copy link

Member

javiereguiluz commentedJul 7, 2017

Thisfixes#7282.

Stop using the deprecated "serializer.mapping.cache.apc" service

1df880f

carsonbot added the Status: Needs Review label

Jul 7, 2017

xabbuh reviewed

Jul 9, 2017

View reviewed changes

serializer.rst Outdated

		));

		..versionadded::3.1
		The ``serializer.mapping.cache.doctrine.apc`` service was introduced in 3.1

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Theserializer.mapping.cache.doctrine.apc service is now also deprecated since Symfony 3.2 (seesymfony/symfony#19236).

Copy link

Member

We should instead drop theframework.serializer.cache config option entirely here. In this case, the FrameworkBundle will decorate theClassMetadataFactory with an instance ofCacheClassMetadataFactory which leverages the already installed and preconfigured cache configuration (i.e. using APCu when present).

Copy link

Member

xabbuh commentedJul 9, 2017

By the way, this option was also deprecated in Symfony 3.1 (seesymfony/symfony#18630).

Copy link

Member

xabbuh commentedJul 9, 2017

changelog fixed accordingly insymfony/symfony@b033e79

Removed some deprecated option and service

5c58231

Copy link

MemberAuthor

javiereguiluz commentedJul 10, 2017

thanks for the review and the explanation. This should be fixed now.

xabbuh reviewed

Jul 10, 2017

View reviewed changes

serializer.rst

		# ...
		serializer:
		cache:serializer.mapping.cache.apc
		cache:id.of.my.own.cache.service

Copy link

Member

xabbuhJul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Instead of using theframework.serializer.cache option we should explain to configure thecache.serializer (which defaults tocache.system) service through theframework.cache.pools option.