Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated code example for LDAP integration#7917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The LdapClient class mentioned in the code example has been deprecated.The update example, uses the Ldap class directly, as is recommended inthe deprecation notice.
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for fixing this!
It seems that there are some indentation issues in the pull request. Maybe you are using tabs instead of spaces?
pmlt commentedMay 22, 2017
Sorry about that! I have corrected it by adding a commit to this PR; let me know if you want me to squash my commits and submit a new PR. |
security/ldap.rst Outdated
| true, | ||
| )); | ||
| ->setDefinition('ext_ldap_adapter', new Definition(Ldap::class, array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should beAdapter::class instead ofLdap::class here
pmlt commentedMay 26, 2017
Indeed... sorry about that. Should be good now (I hope)... |
xabbuh commentedMay 26, 2017
Thank you@pmlt. |
This PR was squashed before being merged into the 3.2 branch (closes#7917).Discussion----------Updated code example for LDAP integrationThe LdapClient class mentioned in the code example has been deprecated.The update example, uses the Ldap class directly, as is recommended inthe deprecation notice.Commits-------91e3e7d Updated code example for LDAP integration
* 3.2: (22 commits) setfacl commands in the right order [#7941] use class constant Update guard_authentication.rst Fix typo Fixed code indentation use Ldap instead of the deprecated LdapClient Fix choice keys and values for custom field types [#7946] fix PHP parameter config example Tiny clarification to Finder component docs [#7917] add LDAP extension link Updated code example for LDAP integration Syntax to create an email Update usage.rst Correct default firewall name on Security docs Fix small typo Change some examples to remove references to gender types Remove remember me from interactive login examples added missing ClassMetadata incorrect placeholdes for leave/enter transitions Update caution about eraseCredentials ...
* 3.4: (27 commits) setfacl commands in the right order add missing options allowed with an env variable [#7941] use class constant Update guard_authentication.rst Fix typo in a class name Fix typo Fixed trivial code example typo Fix typo Fix method reference (`getSubscribedServices()` instead of `getSubscribedEvents()`) Fixed code indentation use Ldap instead of the deprecated LdapClient Fix choice keys and values for custom field types [#7946] fix PHP parameter config example Tiny clarification to Finder component docs [#7917] add LDAP extension link Updated code example for LDAP integration Syntax to create an email Update usage.rst Correct default firewall name on Security docs Fix small typo ...
The LdapClient class mentioned in the code example has been deprecated.
The update example, uses the Ldap class directly, as is recommended in
the deprecation notice.