Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated code example for LDAP integration#7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
pmlt wants to merge5 commits intosymfony:3.2frompmlt:update_ldap_code_example

Conversation

@pmlt
Copy link
Contributor

The LdapClient class mentioned in the code example has been deprecated.
The update example, uses the Ldap class directly, as is recommended in
the deprecation notice.

The LdapClient class mentioned in the code example has been deprecated.The update example, uses the Ldap class directly, as is recommended inthe deprecation notice.
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for fixing this!

It seems that there are some indentation issues in the pull request. Maybe you are using tabs instead of spaces?

@xabbuhxabbuh added this to the3.2 milestoneMay 22, 2017
@pmlt
Copy link
ContributorAuthor

Sorry about that! I have corrected it by adding a commit to this PR; let me know if you want me to squash my commits and submit a new PR.

true,
));
->setDefinition('ext_ldap_adapter', new Definition(Ldap::class, array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should beAdapter::class instead ofLdap::class here

@pmlt
Copy link
ContributorAuthor

Indeed... sorry about that. Should be good now (I hope)...

@xabbuh
Copy link
Member

Thank you@pmlt.

xabbuh added a commit that referenced this pull requestMay 26, 2017
This PR was squashed before being merged into the 3.2 branch (closes#7917).Discussion----------Updated code example for LDAP integrationThe LdapClient class mentioned in the code example has been deprecated.The update example, uses the Ldap class directly, as is recommended inthe deprecation notice.Commits-------91e3e7d Updated code example for LDAP integration
xabbuh added a commit that referenced this pull requestMay 26, 2017
@xabbuhxabbuh closed thisMay 26, 2017
xabbuh added a commit that referenced this pull requestJun 3, 2017
* 3.2: (22 commits)  setfacl commands in the right order  [#7941] use class constant  Update guard_authentication.rst  Fix typo  Fixed code indentation  use Ldap instead of the deprecated LdapClient  Fix choice keys and values for custom field types  [#7946] fix PHP parameter config example  Tiny clarification to Finder component docs  [#7917] add LDAP extension link  Updated code example for LDAP integration  Syntax to create an email  Update usage.rst  Correct default firewall name on Security docs  Fix small typo  Change some examples to remove references to gender types  Remove remember me from interactive login examples  added missing ClassMetadata  incorrect placeholdes for leave/enter transitions  Update caution about eraseCredentials  ...
xabbuh added a commit that referenced this pull requestJun 3, 2017
* 3.4: (27 commits)  setfacl commands in the right order  add missing options allowed with an env variable  [#7941] use class constant  Update guard_authentication.rst  Fix typo in a class name  Fix typo  Fixed trivial code example typo  Fix typo  Fix method reference (`getSubscribedServices()` instead of `getSubscribedEvents()`)  Fixed code indentation  use Ldap instead of the deprecated LdapClient  Fix choice keys and values for custom field types  [#7946] fix PHP parameter config example  Tiny clarification to Finder component docs  [#7917] add LDAP extension link  Updated code example for LDAP integration  Syntax to create an email  Update usage.rst  Correct default firewall name on Security docs  Fix small typo  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz requested changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

4 participants

@pmlt@xabbuh@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp