Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[POC][DO NOT MERGE] Added improved diff lexer#7806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
weaverryan commentedMay 1, 2017
@wouterj This is a DoNotMerge... but I want us to merge it :). I know this was a quick experiment - what's missing? Thanks! |
weaverryan commentedMay 8, 2017
Ping@wouterj! I had another idea since I can see how powerful this is... Could wenot use the A) Does what your lexer does now - looks for a Wouldn't that allow us to have non-copiable diffs AND highlighting? |
xabbuh commentedMay 12, 2017
The code block added in#7868 is a good example for this diff and could be adapted accordingly here. |
weaverryan commentedNov 18, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@bellisk! You should totally check this out ;) |
javiereguiluz commentedFeb 11, 2018
@wouterj just asking: what's the plan for this PR? Are we going to finish it to replace the existing |
javiereguiluz commentedMar 6, 2019
I'm closing this PR as "won't merge" ... because we're working on a new doc builder which will be completely incompatible with this. But the idea is very nice ... so we'll implement it in the new builder. Thanks. |
wouterj commentedMar 7, 2019
What syntax highlighter is used in the new builder? |
javiereguiluz commentedMar 7, 2019
I've replied to you via Slack with some more details about the upcoming doc builder. Thanks. |
Just to play with something discussed this afternoon: Allowing to show diff, but making
+/-not copyable.View the page on platform.sh:
And make sure you inject the following CSS when viewing:
/cc@weaverryan