Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Form] Make difference between data and empty_data options more visisble#7802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+44 −24
Merged
Changes fromall commits
Commits
Show all changes
10 commits Select commitHold shift + click to select a range
87b3542 explicit differences between 'data' & 'empty_data' in FormType
HeahDude67c93b6 fix typo
HeahDude242941a improved accuracy
HeahDude4fd2d96 Addressed @stof's comment
HeahDude5f3813d Updated the example add added a caution
HeahDude188f0ab Tried to write the important points more explicitly
wouterjd552ea3 Readd mixed type for empty_data, it can be string, array or object
wouterjf375489 Better explain empty_data values
wouterjdf9b878 Fixed a minor typo
javiereguiluz64e3984 Fixed a minor typo
javiereguiluzFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
9 changes: 8 additions & 1 deletionform/use_empty_data.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18 changes: 10 additions & 8 deletionsreference/forms/types/options/data.rst.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,21 @@ | ||
| data | ||
| ~~~~ | ||
| **type**: ``mixed`` **default**: Defaults to field of the underlyingstructure. | ||
| When you create a form, each field initially displays the value of the | ||
| corresponding property of the form's domain data (e.g. if you bind an object to | ||
| the form). If you want to override this initial value for the form or | ||
| an individual field, you can set it in the data option:: | ||
| $builder->add('token', 'hidden', array( | ||
| 'data' => 'abcdef', | ||
| )); | ||
| ..caution:: | ||
| The ``data`` option *always* overrides the value taken from the domain data | ||
| (object) when rendering. This means the object value is also overriden when | ||
| the form edits an already persisted object, causing it to lose it's | ||
| persisted value when the form is submitted. |
41 changes: 26 additions & 15 deletionsreference/forms/types/options/empty_data.rst.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.