Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Deprecated the SYMFONY__ variables#7738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| The support of the special ``SYMFONY__`` environment variables was | ||
| deprecated in Symfony 3.3 and it will be removed in 4.0. Instead of | ||
| using those variables, define regular environment variables and get | ||
| their values using the ``%env(...)%`` syntax in your config files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"their value"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm confused about this. I don't know which is the best option here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have no doubt in French we definitely mean "each" when using "their". To me in this case, each environment variable has one value and not many, I've found many discussions on the web, looks like this confusion is global, seehttp://english.stackexchange.com/questions/131430/should-a-noun-after-the-determiner-their-take-in-the-form-of-singular-or-of-pl for a reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"their values" sounds right to me
xabbuh commentedApr 15, 2017
Thank you Javier. |
Thisfixes#7695.