Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update hostname_pattern.rst#7663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
`Symfony\Component\Routing\RouteCollection::addCollection` accepts one argument on type `RouteCollection` that is why`$collection->addCollection($loader->import("@AcmeHelloBundle/Resources/config/routing.php"), '', array(), array(), array(), 'hello.example.com');` is not correct.HeahDude approved these changesMar 26, 2017
Contributor
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch! Should be merged in 2.7.
| $collection = new RouteCollection(); | ||
| $collection->addCollection($loader->import("@AcmeHelloBundle/Resources/config/routing.php"), '', array(), array(), array(), 'hello.example.com'); | ||
| $collection->addCollection($importedCollection); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we don't need to wrap the imported collection in another collection, but can do the following instead (we can then remove theuse statement too):
$collection =$loader->import("@AcmeHelloBundle/Resources/config/routing.php");$collection->setHost('hello.example.com');return$collection;
Member
xabbuh commentedApr 8, 2017
Thank you@krlove. |
xabbuh added a commit that referenced this pull requestApr 8, 2017
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes#7663).Discussion----------Update hostname_pattern.rst`Symfony\Component\Routing\RouteCollection::addCollection` accepts one argument of type `RouteCollection` that is why`$collection->addCollection($loader->import("@AcmeHelloBundle/Resources/config/routing.php"), '', array(), array(), array(), 'hello.example.com');` is not correct.Commits-------71dd533 Update hostname_pattern.rst
xabbuh added a commit that referenced this pull requestApr 8, 2017
xabbuh added a commit that referenced this pull requestApr 9, 2017
* 2.7: (48 commits) docs: choice constraints reference [#7707] minor tweak Fixed code block under "Custom Messages" [#7744] fix XSD locations Minor XML codes fixes [#7686] tweak the example code [#7663] update the PHP example code Update hostname_pattern.rst Add missing ";" Use HTTP instead of http Fixed indentation in security.rst Be consistent on service name Fix missing / Fix trusted hosts example regular expressions fixup comment Testing: Fix typo from#6427 Update apache_router.rst Update fortrabbit.rst Fix some YAML codes Add missing trailing comma & Fix foreach code ...
xabbuh added a commit that referenced this pull requestApr 13, 2017
* 2.8: (48 commits) docs: choice constraints reference [#7707] minor tweak Fixed code block under "Custom Messages" [#7744] fix XSD locations Minor XML codes fixes [#7686] tweak the example code [#7663] update the PHP example code Update hostname_pattern.rst Add missing ";" Use HTTP instead of http Fixed indentation in security.rst Be consistent on service name Fix missing / Fix trusted hosts example regular expressions fixup comment Testing: Fix typo from#6427 Update apache_router.rst Update fortrabbit.rst Fix some YAML codes Add missing trailing comma & Fix foreach code ...
xabbuh added a commit that referenced this pull requestApr 13, 2017
* 3.2: (60 commits) docs: choice constraints reference [#7707] minor tweak Fixed code block under "Custom Messages" [#7744] fix XSD locations Minor XML codes fixes [#7686] tweak the example code [#7663] update the PHP example code Update hostname_pattern.rst Add missing ";" Use HTTP instead of http Fixed indentation in security.rst Be consistent on service name Fix missing / typo fix Fix trusted hosts example regular expressions add reference built in listener for kernel.response event in >=3.1 fixup comment Testing: Fix typo from#6427 Update apache_router.rst Update fortrabbit.rst ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony\Component\Routing\RouteCollection::addCollectionaccepts one argument of typeRouteCollectionthat is why$collection->addCollection($loader->import("@AcmeHelloBundle/Resources/config/routing.php"), '', array(), array(), array(), 'hello.example.com');is not correct.