Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Document the CsvEncoder and the YamlEncoder#7654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
GuilhemN wants to merge1 commit intosymfony:3.2fromGuilhemN:ENCODER

Conversation

@GuilhemN
Copy link
Contributor

@GuilhemNGuilhemN commentedMar 19, 2017
edited
Loading

Document the CsvEncoder and the YamlEncoder introduced insymfony/symfony#19197 andsymfony/symfony#19326.

Copy link
Contributor

@Nek-Nek- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍


The ``JsonEncoder`` is much simpler and is based on the PHP
:phpfunction:`json_encode` and:phpfunction:`json_decode` functions.
This encoder requires the:doc:`Yaml Component</components/yaml>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Missing a version added note for this one.

GuilhemN reacted with thumbs up emoji
Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok I've missed it :)

wouterj added a commit that referenced this pull requestOct 13, 2017
…r (GuilhemN)This PR was submitted for the 3.2 branch but it was merged into the 3.3 branch instead (closes#7654).Discussion----------[Serializer] Document the CsvEncoder and the YamlEncoderDocument the CsvEncoder and the YamlEncoder introduced insymfony/symfony#19197 andsymfony/symfony#19326.Commits-------6944ea1 [Serializer] Document the CsvEncoder and the YamlEncoder
wouterj added a commit that referenced this pull requestOct 13, 2017
@wouterj
Copy link
Member

Thanks@GuilhemN for documenting these new serializers! Unfortunately, we've waited so long with merging this PR, we cannot merge it in 3.2 (as it's no longer maintained). So I've merged this in 3.3.

I've also slightly changed the wording inb3f570e , because it didn't read nicely anymore now you've moved the json encoder above.

GuilhemN reacted with hooray emoji

@GuilhemNGuilhemN deleted the ENCODER branchOctober 13, 2017 15:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@Nek-Nek-Nek- approved these changes

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GuilhemN@wouterj@Nek-@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp