Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Twig Extensions Reference minor brush-up#7613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mpdude wants to merge4 commits intosymfony:masterfrommpdude:patch-2

Conversation

@mpdude
Copy link
Contributor

Especially clarify that the "Twig Extensions Repository" has nothing to do with Symfony Standard Edition

Especially clarify that the "Twig Extensions Repository" has nothing to do with Symfony Standard Edition

  Technically, most of the extensions live in the `Twig Bridge`_. That code
might give you some ideas when you need to write your own Twig extension
as described in:doc:`/templating/twig_extension.rst`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You have to omit the file extension here.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, fixed

:ref:`functions<reference-twig-functions>`,:ref:`filters<reference-twig-filters>`,
:ref:`tags<reference-twig-tags>` and:ref:`tests<reference-twig-tests>`
that are available when using the Symfony Core Framework.
TheSymfonyFrameworkaddsquite a few extra:ref:`functions<reference-twig-functions>`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

framework

TheSymfonyFrameworkaddsquite a few extra:ref:`functions<reference-twig-functions>`,
:ref:`filters<reference-twig-filters>`,:ref:`tags<reference-twig-tags>`
and:ref:`tests<reference-twig-tests>` to seamlessly integrate the various
Symfony Components with Twig templates. The following sections describe these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

components

..note::

This reference only covers the Twig extensions provided by the Symfony
Framework. You are probably using some other bundles as well, and those
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

framework

.. _`the official Twig Extensions documentation`:http://twig.sensiolabs.org/doc/extensions/index.html
.. _`Twig Extensions repository`:https://github.com/twigphp/Twig-extensions
.. _`Twig Extensions documentation`:http://twig-extensions.readthedocs.io/en/latest/
.. _`KernelEvents`:https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/KernelEvents.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This isn't used anywhere here, is it?

@mpdude
Copy link
ContributorAuthor

@xabbuh Thanks for the review, fixed all your remarks

@xabbuh
Copy link
Member

👍

Status: Reviewed

@javiereguiluz
Copy link
Member

@mpdude I'm really sorry but your PR needs to be rebased. Could you do that for us? Thanks!

@mpdude
Copy link
ContributorAuthor

@javiereguiluz done, merged master

@javiereguiluz
Copy link
Member

javiereguiluz commentedApr 30, 2017
edited
Loading

@mpdude thanks for your contribution and for the rebase! It's merged now.

@mpdudempdude deleted the patch-2 branchApril 30, 2017 15:09
xabbuh pushed a commit that referenced this pull requestMay 3, 2017
This PR was squashed before being merged into the master branch (closes#7613).Discussion----------Twig Extensions Reference minor brush-upEspecially clarify that the "Twig Extensions Repository" has nothing to do with Symfony Standard EditionCommits-------b48b4c4 Twig Extensions Reference minor brush-up
xabbuh added a commit that referenced this pull requestMay 3, 2017
* 2.7:  minor#7613 Twig Extensions Reference minor brush-up (mpdude)  Update Title in controller.rst  Update scheme.rst  Update requirements.rst  [#7845] minor tweaks  Update translation_domain.rst.inc  Update page_creation.rst to correct hidden colon  Update forms.rst  Minor reword  Update deployment.rst  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()  Better explain how to enable the validation component and its annotations  Fix the link to ConEmu (it is now hosted on GitHub)  Add annotation examples to match a route based on the host  Minor reword to improve readability  Minor reword and reformatting  Add security stateless tip  typo
xabbuh added a commit that referenced this pull requestMay 3, 2017
* 2.8:  minor#7613 Twig Extensions Reference minor brush-up (mpdude)  Update Title in controller.rst  Update scheme.rst  Update requirements.rst  [#7845] minor tweaks  Update translation_domain.rst.inc  Update page_creation.rst to correct hidden colon  Update forms.rst  Fixed the form types of the buttons in the Form reference  Minor reword  Update deployment.rst  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()  Better explain how to enable the validation component and its annotations  Fix the link to ConEmu (it is now hosted on GitHub)  Add annotation examples to match a route based on the host  Minor reword to improve readability  Minor reword and reformatting  Add security stateless tip  typo
xabbuh added a commit that referenced this pull requestMay 3, 2017
xabbuh added a commit that referenced this pull requestMay 3, 2017
* 3.2: (28 commits)  [#7613] remove reference to AsseticBundle  minor#7613 Twig Extensions Reference minor brush-up (mpdude)  Update Title in controller.rst  Update scheme.rst  Update requirements.rst  [#7845] minor tweaks  Update translation_domain.rst.inc  Update page_creation.rst to correct hidden colon  Update forms.rst  Fixed the form types of the buttons in the Form reference  [#7832] use bin/console for Symfony 3.x  Minor reword  Update deployment.rst  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()  Better explain how to enable the validation component and its annotations  Fix the link to ConEmu (it is now hosted on GitHub)  Add annotation examples to match a route based on the host  Minor reword to improve readability  Update service_container.rst  Minor reword and reformatting  ...
weaverryan added a commit that referenced this pull requestMay 5, 2017
* origin/master: (36 commits)  Use the short Yaml syntax for service definition  [#7613] remove reference to AsseticBundle  minor#7613 Twig Extensions Reference minor brush-up (mpdude)  Fix service locator declaration  Minor reword  Update Title in controller.rst  Update scheme.rst  Update requirements.rst  [3.3] Document FQCN named controllers  Document FQCN named controllers  Use the short tag syntax  [#7845] minor tweaks  Update translation_domain.rst.inc  Update page_creation.rst to correct hidden colon  Update forms.rst  Rewords  Fixed the form types of the buttons in the Form reference  [#7832] use bin/console for Symfony 3.x  Minor reword  Update deployment.rst  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

+1 more reviewer

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mpdude@xabbuh@javiereguiluz@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp