Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Improve specification explanation#7601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
RFC 2616 and RFC 7234 define that a recipient MUST ignore Expires header if one of `s-max-age` or `max-age` header is defined.
http_cache/expiration.rst Outdated
| .. _`expiration model`:http://tools.ietf.org/html/rfc2616#section-13.2 | ||
| .. _`FrameworkExtraBundle documentation`:https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/cache.html | ||
| .. _`RFC 7234 - Caching`:https://tools.ietf.org/html/rfc7234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would make this a deep link tohttps://tools.ietf.org/html/rfc7234#section-5.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah no, maybe that's not the best idea ashttps://tools.ietf.org/html/rfc7234#section-4.2.1 also contains information about the process that must be applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, the process is well explained in section 4.2.1
http_cache/expiration.rst Outdated
| ..note:: | ||
| Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is | ||
| ignored when a ``s-max-age`` or ``max-age`` header is defined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In fact,s-maxage (note the missing second dash) andmax-age are not headers, but are directives of theCache-Control header.
http_cache/expiration.rst Outdated
| ..note:: | ||
| Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is | ||
| ignored when a ``s-max-age`` or ``max-age`` directives are defined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should remove thea before directives.
http_cache/expiration.rst Outdated
| ..note:: | ||
| Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is | ||
| ignored when ``s-max-age`` or ``max-age`` directives are defined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[...] when thes-maxage ormax-age directive of theCache-Control header is defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh Minor comment, I don't get this change, it seems to me that both can be set at the same time, does it matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, but it is enough for one of them to be present in order to ignore theExpires header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fair enough then.
xabbuh commentedApr 15, 2017
Thank you@matthieu88160. |
…guiluz)This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes#7601).Discussion----------Improve specification explanationRFC 2616 and RFC 7234 define that a recipient MUST ignore Expires header if one of `s-max-age` or `max-age` header is defined.Commits-------ce64af5 Update expiration.rst46e6408 Update expiration.rstb66e4d7 Update expiration.rst13102da Update expiration.rst8666bed Minor reword and fixed the line length232c029 Improve specification explanation
* 2.7: (31 commits) Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" Fixed a syntax issue Use backticks#7311 choice_value callback argument can be null Fixed broken links for nginx & FastCgiExternalServer Update dialoghelper.rst ...
* 2.8: (46 commits) [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests Added the changes suggested by reviewers [#7620] use generate() in PHP templates before 2.8 Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" ...
RFC 2616 and RFC 7234 define that a recipient MUST ignore Expires header if one of
s-max-ageormax-ageheader is defined.