Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated "Checking for Roles inside a Voter" for 2.8#7524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedApr 15, 2017
This one should be easy to review. We're just removing some contents that are not true for 2.8. Thanks! |
security/voters.rst Outdated
| The solution is to inject the ``service_container`` service and use it to get | ||
| the ``security.authorization_checker`` service and call to the ``isGranted()`` | ||
| method. Another solution is to upgrade your Symfony version, because this issue | ||
| was fixed starting from Symfony 3.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The linked ticket is mentioning the debug access decision manager introduced in 3.1 but how could this fix the problem of circular dependency for voters requiring the manager? Are we sure this is fixed? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you remove this note, it should be good to merge.
wouterj commentedNov 12, 2017
This will be a tricky one to merge up, but I'll take care of that. Thanks! |
…eguiluz)This PR was squashed before being merged into the 2.8 branch (closes#7524).Discussion----------Updated "Checking for Roles inside a Voter" for 2.8As mentioned insymfony/symfony#21701 this issue was fixed in 3.1 ... so 2.8 still has this issue.Commits-------ee724b5 Updated "Checking for Roles inside a Voter" for 2.8
As mentioned insymfony/symfony#21701 this issue was fixed in 3.1 ... so 2.8 still has this issue.