Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[ExpressionLanguage] Document ExpressionFunction::fromPhp#7517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ExpressionFunction::fromPhp('strtoupper'); | ||
| It allows namespaced PHP function where second parameter must be defined to name expression:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[...] where the second [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done
xabbuh commentedFeb 21, 2017
Please also add a ..versionadded::3.3 The ``ExpressionFunction::fromPhp()`` method was introduced in Symfony 3.3. |
xabbuh commentedFeb 21, 2017
👍 Status: Reviewed |
maidmaid commentedFeb 21, 2017
Result:
|
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
xabbuh commentedFeb 22, 2017
@maidmaid This should work. The template used to render the preview is not exactly the same as the one used on symfony.com (we don't update it every time small changes are made to the website). |
maidmaid commentedFeb 22, 2017
Cool, thank you for your reviews :) |
| ..tip:: | ||
| You can create an expression function from a PHP function with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"You can create ..." => "To create ..."
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
xabbuh commentedFeb 28, 2017
Thank you@maidmaid. |
…hp (maidmaid, javiereguiluz)This PR was merged into the master branch.Discussion----------[ExpressionLanguage] Document ExpressionFunction::fromPhpcfsymfony/symfony#21122Commits-------415c4ec Update extending.rst478400a Minor reword059155f Add versionadded6c9e09d Fix typoc70ea7f Fix typo6d9af37 Add fromPhp tip
cfsymfony/symfony#21122