symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Update 'ide' example in framework.rst#7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

harcod wants to merge7 commits intosymfony:3.2fromharcod:patch-1

Closed

Update 'ide' example in framework.rst#7513

harcod wants to merge7 commits intosymfony:3.2fromharcod:patch-1

Conversation

Copy link

Contributor

harcod commentedFeb 19, 2017

The example 'ide' configuration was different from the actual format required for PhpStorm. See README athttps://github.com/aik099/PhpStormProtocol to verify the correct format as

phpstorm://open?url=file://%f&line=%l

Update 'ide' example in framework.rst

1588242

The example 'ide' configuration was different from the actual format required for PhpStorm.  See README athttps://github.com/aik099/PhpStormProtocol

carsonbot added the Status: Needs Review label

Feb 19, 2017

javiereguiluz approved these changes

Feb 22, 2017

View reviewed changes

Copy link

Member

javiereguiluz left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

I've asked in the Symfony Slack and some actual users of PHPStorm have said that the proposed change is correct.

Thanks@harcod.

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels

Feb 22, 2017

javiereguiluz requested changes

Feb 22, 2017

View reviewed changes

Copy link

Member

javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm sorry ... but there has been some confusion!! The existing syntax works, but the proposed changes don't work!!

Then we'll need more reviews to accept this proposal.

Copy link

Contributor

pierredup commentedFeb 22, 2017

The syntaxphpstorm://open?url=file://%f&line=%l is only used by the pluginhttps://github.com/aik099/PhpStormProtocol.
Since PHPStorm 8 EAP 138.190, PHPStorm supports the protocol natively using the existing syntax used by the docs.

So IMO there is no change needed.

Copy link

Member

xabbuh commentedFeb 22, 2017

Status: Reviewed

Copy link

Member

xabbuh commentedFeb 22, 2017

Since PHPStorm 8 EAP 138.190, PHPStorm supports the protocol natively using the existing syntax used by the docs.

Does that mean we should update the default value in the Symfony code instead?

Copy link

Contributor

pierredup commentedFeb 22, 2017

I've created a PR to update the value in Symfonysymfony/symfony#21712

Provide specific instructions for using the 'phpstorm' ide setting on…

b5db60d

… various platforms.

Copy link

ContributorAuthor

harcod commentedFeb 22, 2017

Updated docs as suggested by@pierredup insymfony/symfony#21712

harcod mentioned this pull request

Feb 22, 2017

[FrameworkBundle] Add PHPStorm helper link format for Macsymfony/symfony#21712

Closed

pierredup approved these changes

Feb 23, 2017

View reviewed changes

Copy link

Contributor

pierredup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Reflects changes made for phpstorm-mac bysymfony/symfony#21712

f25a4e9

xabbuh added the On hold label

Feb 24, 2017

harcod added2 commits

February 24, 2017 08:03

Changed phpstorm-mac to phpstorm-core bysymfony/symfony#21712

60b603d

Updated to phpstorm-protocol as changed bysymfony/symfony#21712

0ce8ef0

HeahDude approved these changes

Feb 28, 2017

View reviewed changes

phpstorm-protocol was eliminated since the Windows and Linux handlers…

6e8e0be

… now support the same format scheme as MacOS.

pierredup approved these changes

Mar 1, 2017

View reviewed changes

Copy link

Contributor

pierredup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Copy link

ContributorAuthor

harcod commentedMar 1, 2017

This documentation change reflects the changes made bysymfony/symfony#21813

HeahDude reviewed

Mar 1, 2017

View reviewed changes

reference/configuration/framework.rst Outdated

		links that open those files right inside your browser. If you prefer to open
		those files in your favorite IDE or text editor, set this option to any of the
		following values: ``phpstorm`` (requires `PhpStormProtocol`_), ``sublime``,
		following values: ``phpstorm``, ``sublime``,

Copy link

Contributor

HeahDudeMar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This line can now be longer.

made line longer as requested

2cbec8c

HeahDude approved these changes

Mar 1, 2017

View reviewed changes

Copy link

Contributor

HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 👍

Copy link

Member

xabbuh commentedMar 3, 2017

Thank you@harcod.

xabbuh added a commit that referenced this pull request

Mar 3, 2017

minor#7513Update 'ide' example in framework.rst (harcod)

6940a12

This PR was squashed before being merged into the 3.2 branch (closes#7513).Discussion----------Update 'ide' example in framework.rstThe example 'ide' configuration was different from the actual format required for PhpStorm.  See README athttps://github.com/aik099/PhpStormProtocol to verify the correct format as> phpstorm://open?url=file://%f&line=%lCommits-------606bfb1 Update 'ide' example in framework.rst

xabbuh added a commit that referenced this pull request

Mar 3, 2017

[#7513] fix line length

631c68b

xabbuh closed this

Mar 3, 2017

xabbuh added a commit that referenced this pull request

Mar 4, 2017

Merge branch '3.2'

c7af8cf

* 3.2: (24 commits)  Minor rewords  Update session_configuration.rst  [#7522] minor wording improvement  [#7513] fix line length  Update 'ide' example in framework.rst  [#7219] move versionadded in front of description  Improved the image for Doctrine + Web Debug Toolbar  [Serializer] Docs for the PropertyInfo integration  Finished this PR  section chronology in comment  Removed the example about Redis  Update cache.rst  Update bundles/configuration.rst  Fix typos  Removed tip that was meant for the 2.x versions  fix usage of the session flag bag API  Add caution related to deprecate mail transport  Use https URLs when possible  [Requirements] Clarify what are JSON and ctype  Proposed a minor reword  ...