Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Minor fixes about bundle overridding#7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The old sentence was confusing. This one works better.
Its better to use e.g. here cause that is just an example. Doesn't always going to be in that path.
The word 'or' is clear. / not so much.
Titles use caps.Unnecessary sentence.
This does only apply to Symfony >= 3.0.
Jean85 commentedFeb 16, 2017
LGTM 👍 |
bundles/override.rst Outdated
| $builder->add('name', new CustomType()); | ||
| Existing form types can be modified defining "form type extensions". | ||
| For more information, see:doc:`/form/create_form_type_extension`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
bundles/inheritance.rst Outdated
| If you refertoresources without usingthe ``@BundleName`` shortcut, they | ||
| can't beoverridden in this way. | ||
| You needtousethe ``@BundleName`` shortcut when refering to resources | ||
| so theycan besuccessfully overridden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There has been confusion in the past about which resources we refer to here. I think we should make more clear that this note does not apply when we talk about templates as the overriding of them works no matter if you use the bundle syntax or the native Twig namespace syntax (I know that the syntax is not exactly the same as what we use to refer to other resources, but that's not so obvious).
bundles/override.rst Outdated
| rather than:: | ||
| $builder->add('name', new CustomType()); | ||
| Existing form types can be modified defining "form type extensions". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I propose:"form type extensions" ->*form type extensions*
xabbuh commentedApr 15, 2017
Thank you Javier. |
…javiereguiluz)This PR was merged into the 2.7 branch.Discussion----------Minor fixes about bundle overriddingThis finishes#6985.Commits-------c9a52ae Added the changes suggested by reviewersd5cd8d0 Reworded the section about form overridding600d302 Update installation.rst62bfc21 Update prepend_extension.rst2f837d6 Update override.rst3433e50 Update installation.rstf684bdd Update inheritance.rst
* 2.7: [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests Added the changes suggested by reviewers Fixed status code test Improved a test Merged and improved the articles about testing + authentication Reworded the section about form overridding Update installation.rst Update prepend_extension.rst Update override.rst Update installation.rst Update inheritance.rst Unify placeholders in documentation and code
* 2.8: (46 commits) [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests Added the changes suggested by reviewers [#7620] use generate() in PHP templates before 2.8 Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" ...
* 3.2: (71 commits) Rewriting the service container docs Minor reword Adding a tip for validation in forms without class [#7217] add versionadded directives [#7203] merge note and versionadded directive Use the new configurator YAML syntax Added a note about the .htaccess files included by Symfony apps Made unmapped field example in forms chapter more descriptive [#7507] fix namespace [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests [#7204] link to API doc Added docs for JsonResponse::fromJsonString Added the changes suggested by reviewers [#7620] use generate() in PHP templates before 2.8 Fixed the RST syntax Improve example context Minor formatting changes [#7519] some minor tweaks ...
This finishes#6985.