Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Covering two missing Cache adapters introduced in 3.2#7424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
| $directory = null | ||
| ); | ||
| Php Files Cache Adapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Php Files ->PHP Files ? (after all, PHP is an acronym)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm going to leave this - I did it because the name of the class is PhpFilesAdapter... but I could see it either way (I would normally 100% agree)
components/cache/cache_pools.rst Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
| This adapter is very similar to the Filesystem adapter, except that the saving creates | ||
| a ``.php`` file, which is included on fetch (allowing the file to me saved in OpCache):: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
me ->be
| ``''``) and ``defaultLifetime`` (default: ``0``) and adapts them to make them | ||
| work in the underlying Doctrine cache. | ||
| Php Array Cache Adapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same here.Php ->PHP ?
components/cache/cache_pools.rst Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
| This adapter is a highly performant way to cache static data (e.g. application configuration) | ||
| that is optimized and preloaded into OpCache memory storage:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OpCache ->OPcache (according tohttp://php.net/manual/en/book.opcache.php)
components/cache/cache_pools.rst Outdated
| use Symfony\Component\Cache\Adapter\PhpArrayAdapter; | ||
| use Symfony\Component\Cache\Adapter\PhpFilesAdapter; | ||
| // somehow, decide it's time to warmup the cache! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
warmup ->warm up
…weaverryan)This PR was merged into the 3.2 branch.Discussion----------Covering two missing Cache adapters introduced in 3.2Hi guys!These are 2 missing adapters that were introduced in 3.2!symfony/symfony#18894 andsymfony/symfony#18823Cheers!Commits-------a3e69e2 Tweaks based on feedback!1b6cb69 Covering two missing adapters introduced in 3.2
Hi guys!
These are 2 missing adapters that were introduced in 3.2!symfony/symfony#18894 andsymfony/symfony#18823
Cheers!