Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added a note about not using the ClassLoader component#7383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
components/class_loader.rst Outdated
| If your application uses Composer's class loading mechanism and PHP 7 caching | ||
| features, there's no need to use this component to load classes. That's why | ||
| this component may be deprecated anytime soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The last sentence sounds a bit vague. Shouldn't we just omit it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've reworded it ... because the component is deprecated as ofsymfony/symfony#21353
components/class_loader.rst Outdated
| ..caution:: | ||
| The ClassLoader component was deprecated in Symfony 3.3 and it will be | ||
| removed in 4.0. Alternatively, use the Composer's class loading mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
remove "the" here
| ..caution:: | ||
| The ClassLoader component was deprecated in Symfony 3.3 and it will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Technically, using the past tense here is not correct as 3.3 was released yet. Though I think that's okay as it allows us not to update the sentence in May again. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree. It's not perfect, but it's "good enough".
xabbuh commentedFeb 2, 2017
Okay, let's keep it as is. Status: Reviewed |
…aviereguiluz)This PR was squashed before being merged into the 2.7 branch (closes#7383).Discussion----------Added a note about not using the ClassLoader componentThisfixes#5949.The component will be deprecated soon, so I guess it's OK to start warning our users.Commits-------e96cbf8 Added a note about not using the ClassLoader component
xabbuh commentedFeb 3, 2017
Thank you Javier. I made a minor rewording in0866fb8. Please let me know if you do not agree. |
* 2.7: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions See#7362 bundles/override > Rewrite translations block
* 2.8: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component Update guard_authentication.rst More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions See#7362 bundles/override > Rewrite translations block
* 3.1: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component Update guard_authentication.rst More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions remove unused options parameter from loadManifest See#7362 bundles/override > Rewrite translations block
* 3.2: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component Update guard_authentication.rst More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions Fix doc for yaml parameters constants usage remove unused options parameter from loadManifest Tweaks based on feedback! Covering two missing adapters introduced in 3.2 See#7362 bundles/override > Rewrite translations block
Thisfixes#5949.
The component will be deprecated soon, so I guess it's OK to start warning our users.