Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Console] Update the doc for automatic console logging#7373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
javiereguiluz commentedJan 16, 2017
Yes, we should remove the contents of this article ... but maybe it's too son to remove the article itself. Otherwise, all the |
MemberAuthor
chalasr commentedJan 17, 2017
@javiereguiluz Let's do it like that 👍 |
Member
javiereguiluz commentedJan 17, 2017
@chalasr then we can remove the link entirely and add it later if needed: |
368b538 toa73e932CompareMemberAuthor
chalasr commentedJan 17, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oops, that's what I meant, but forgot "without" in my last sentence :) I made the change |
javiereguiluz approved these changesJan 18, 2017
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
a73e932 tocff3a8dComparecff3a8d to76d2c91CompareMemberAuthor
chalasr commentedJan 18, 2017
I re-added the page title so that other pages can have links to, the travis build was failing if missing. |
symfony-splitter pushed a commit to symfony/console that referenced this pull requestJan 23, 2017
…eshalsall, chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[Console][FrameworkBundle] Log console exceptions| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #10895| License | MIT| Doc PR |symfony/symfony-docs#7373Continues #19382, fixing some issues including:- ability to display the input string for any `InputInterface` implementation (cast to string if possible, use the command name otherwise)- if the input can be casted as string, cleanup the result (from `command "'command:name' --foo=bar" ` to `command "command:name --foo=bar"`)- made `ExceptionLister::$logger` private instead of protected- changed methods name from `onKernel*` to `onConsole*` (e.g. `onConsoleException`) and removed unnecessary doc blocks- Added more testsLog for an exception:> [2016-12-22 00:34:42] app.ERROR: Exception thrown while running command: "cache:clear -vvv". Message: "An error occured!" {"exception":"[object] (RuntimeException(code: 0): An error occured! at /Volumes/HD/Sites/tests/sf-demo-3.2/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php:61)","command":"cache:clear -vvv","message":"An error occured!"} []Commits-------919041c1ad Add Console ExceptionListener9896547a4d Add basic support for automatic console exception logging
fabpot added a commit to symfony/symfony that referenced this pull requestJan 23, 2017
…eshalsall, chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[Console][FrameworkBundle] Log console exceptions| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#10895| License | MIT| Doc PR |symfony/symfony-docs#7373Continues#19382, fixing some issues including:- ability to display the input string for any `InputInterface` implementation (cast to string if possible, use the command name otherwise)- if the input can be casted as string, cleanup the result (from `command "'command:name' --foo=bar" ` to `command "command:name --foo=bar"`)- made `ExceptionLister::$logger` private instead of protected- changed methods name from `onKernel*` to `onConsole*` (e.g. `onConsoleException`) and removed unnecessary doc blocks- Added more testsLog for an exception:> [2016-12-22 00:34:42] app.ERROR: Exception thrown while running command: "cache:clear -vvv". Message: "An error occured!" {"exception":"[object] (RuntimeException(code: 0): An error occured! at /Volumes/HD/Sites/tests/sf-demo-3.2/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php:61)","command":"cache:clear -vvv","message":"An error occured!"} []Commits-------919041c Add Console ExceptionListener9896547 Add basic support for automatic console exception logging
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJan 23, 2017
…eshalsall, chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[Console][FrameworkBundle] Log console exceptions| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #10895| License | MIT| Doc PR |symfony/symfony-docs#7373Continues #19382, fixing some issues including:- ability to display the input string for any `InputInterface` implementation (cast to string if possible, use the command name otherwise)- if the input can be casted as string, cleanup the result (from `command "'command:name' --foo=bar" ` to `command "command:name --foo=bar"`)- made `ExceptionLister::$logger` private instead of protected- changed methods name from `onKernel*` to `onConsole*` (e.g. `onConsoleException`) and removed unnecessary doc blocks- Added more testsLog for an exception:> [2016-12-22 00:34:42] app.ERROR: Exception thrown while running command: "cache:clear -vvv". Message: "An error occured!" {"exception":"[object] (RuntimeException(code: 0): An error occured! at /Volumes/HD/Sites/tests/sf-demo-3.2/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php:61)","command":"cache:clear -vvv","message":"An error occured!"} []Commits-------919041c1ad Add Console ExceptionListener9896547a4d Add basic support for automatic console exception logging
MemberAuthor
chalasr commentedJan 24, 2017
symfony/symfony#21003 has been merged, this is no longer on hold. |
Member
xabbuh commentedFeb 3, 2017
Thank you@chalasr. |
xabbuh added a commit that referenced this pull requestFeb 3, 2017
…(chalasr)This PR was merged into the master branch.Discussion----------[Console] Update the doc for automatic console loggingInsymfony/symfony#21003 we are going to provide automatic error/exception logging for the console, similar to what is done in an HTTP context.In the docs, there is a whole chapter dedicated to this topic. Right now I just removed it, maybe it should be done differently or mentioned somewhere that error/exceptions are automatically logged on the `console` channel?ThanksCommits-------76d2c91 Update the doc for automatic console logging
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insymfony/symfony#21003 we are going to provide automatic error/exception logging for the console, similar to what is done in an HTTP context.
In the docs, there is a whole chapter dedicated to this topic. Right now I just removed it, maybe it should be done differently or mentioned somewhere that error/exceptions are automatically logged on the
consolechannel?Thanks