Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Document that you can't pass empty strings to console options#7363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:2.7fromjaviereguiluz:option_empty_string
Mar 1, 2017

Conversation

@javiereguiluz
Copy link
Member

@xabbuh
Copy link
Member

👍

Status: Reviewed

@chalasr
Copy link
Member

chalasr commentedJan 15, 2017•
edited
Loading

I just added a commit that (I think) improves this situation, I think we should look at it before merging this. Seesymfony/symfony#21228 (comment).
I was afraid that changing this behavior would give a lot of drawbacks, I'm sorry about that.

@javiereguiluz
Copy link
MemberAuthor

I'm putting this PR on hold because the genius@chalasr has managed to solve this issue. Seesymfony/symfony#21228

chalasr reacted with laugh emoji

@chalasr
Copy link
Member

@javiereguiluz fixed on master only due to the potential too much important impact, this stays correct for older branches.

@javiereguiluz
Copy link
MemberAuthor

@chalasr Thanks!

Note to mergers: merge in all branches EXCEPT master.

@xabbuhxabbuh removed the On hold labelMar 1, 2017
@xabbuh
Copy link
Member

Thank you Javier.

@xabbuhxabbuh merged commit9666907 intosymfony:2.7Mar 1, 2017
xabbuh added a commit that referenced this pull requestMar 1, 2017
…ions (javiereguiluz)This PR was merged into the 2.7 branch.Discussion----------Document that you can't pass empty strings to console optionsRelated tosymfony/symfony#21215Commits-------9666907 Document that you can't pass empty strings to console options
xabbuh added a commit that referenced this pull requestMar 1, 2017
…sole options (javiereguiluz)"This reverts commit185e886, reversingchanges made to402b96f.
@xabbuh
Copy link
Member

Reverted in9232842 in themaster branch.

@chalasr
Copy link
Member

I'll look for adding a note to explain the behavior change in 3.3 asap today

@javiereguiluzjaviereguiluz deleted the option_empty_string branchMay 24, 2018 16:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javiereguiluz@xabbuh@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp