remove 'placeholder' from empty-data example#7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

teameh wants to merge1 commit intosymfony:masterfromteameh:master

Closed

remove 'placeholder' from empty-data example#7299

teameh wants to merge1 commit intosymfony:masterfromteameh:master

Conversation

Copy link

teameh commentedDec 29, 2016

This snippet is also included on the [TextType Field] page (http://symfony.com/doc/current/reference/forms/types/text.html) and might trick novice Symfony dev's into using the placeholder for the TextType as well. I think the placeholder can be removed here making the example even more to the point.

remove 'placeholder' from empty-data example

c521b45

carsonbot added the Status: Needs Review label

Dec 29, 2016

Copy link

Contributor

HeahDude commentedDec 30, 2016

Prior to symfony 2.6placeholder option was namedempty_value which could lead to even more confusion.

Not sure this is still relevant though, but I've also a WIP for this option (#6265) that will remove this all together anyway.

Copy link

Author

teameh commentedDec 30, 2016

Prior to symfony 2.6 placeholder option was named empty_value which could lead to even more confusion.

Check, I'm new here, thanks.

Not sure this is still relevant though, but I've also a WIP for this option (#6265) that will remove this all together anyway.

And it's still WIP because you've only changed the docs so far right?

HeahDude mentioned this pull request

Jan 7, 2017

Update example for empty_data.inc#7328

Closed

wouterj mentioned this pull request

Apr 15, 2017

[Form] Make difference between data and empty_data options more visisble#7802

Merged

xabbuh added a commit that referenced this pull request

May 4, 2017

minor#7802[Form] Make difference between data and empty_data option…

7571315

…s more visisble (HeahDude, wouterj, javiereguiluz)This PR was merged into the 2.7 branch.Discussion----------[Form] Make difference between data and empty_data options more visisbleFinishes#6265Fixes#7299,#7596Commits-------64e3984 Fixed a minor typodf9b878 Fixed a minor typof375489 Better explain empty_data valuesd552ea3 Readd mixed type for empty_data, it can be string, array or object188f0ab Tried to write the important points more explicitly5f3813d Updated the example add added a caution4fd2d96 Addressed@stof's comment242941a improved accuracy67c93b6 fix typo87b3542 explicit differences between 'data' & 'empty_data' in FormType