Dec 18, 2016 · Dec 18, 2016 · Dec 18, 2016 · Dec 18, 2016 · Dec 19, 2016 · Dec 19, 2016
diff --git a/forms.rst b/forms.rst
 .. index::
   single: Forms; Field type guessing

 FieldType Options Guessing
 FieldAttributes Guessing
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~

 In addition to guessing the "type" for a field, Symfony can also try to guess
 the correct values of a number of fieldoptions.
 the correct values of a number of fieldattributes.

 .. tip::

    field type options can then be guessed from that information.

 ``required``
    The ``required``option can be guessed based on the validation rules (i.e. is
    The ``required``html attribute can be guessed based on the validation rules (i.e. is
    the field ``NotBlank`` or ``NotNull``) or the Doctrine metadata (i.e. is the
    field ``nullable``). This is very useful, as your client-side validation will
    automatically match your validation rules.

 ``max_length``
    If the field is some sort of text field, then the ``max_length``option can be
 ``maxlength``
    If the field is some sort of text field, then the ``maxlength``html attribute can be
    guessed from the validation constraints (if ``Length`` or ``Range`` is used) or
    from the Doctrine metadata (via the field's length).
Original file line number	Diff line number	Diff line change
Expand Up		@@ -542,11 +542,11 @@ the guessed field.
		.. index::
		single: Forms; Field type guessing

		FieldType Options Guessing
		FieldAttributes Guessing
Copy link Contributor HeahDudeDec 18, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I understand why you did it but this change is not needed since guessers are about to change type's options, actually`required` and`maxlength` are define thanks to the`attr` option in the form factory but the registered doctrine and validation guessers are setting some options too, maybe it's worth documenting them though. I don't know what others think? Copy link ContributorAuthor cailliouxDec 19, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Do you think we should just remove the maxlength part and keep required? Copy link Contributor HeahDudeDec 19, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. No I don't :) I was suggesting to add undocumented guessed options, not to remove these ;) Copy link Contributor HeahDudeJul 29, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This change also needs to be reverted.
		~~~~~~~~~~~~~~~~~~~~~~~~~~~

		In addition to guessing the "type" for a field, Symfony can also try to guess
		the correct values of a number of fieldoptions.
		the correct values of a number of fieldattributes.

		.. tip::

Expand All		@@ -557,13 +557,13 @@ the correct values of a number of field options.
		field type options can then be guessed from that information.

		``required``
		The ``required``option can be guessed based on the validation rules (i.e. is
		The ``required``html attribute can be guessed based on the validation rules (i.e. is
		the field ``NotBlank`` or ``NotNull``) or the Doctrine metadata (i.e. is the
		field ``nullable``). This is very useful, as your client-side validation will
		automatically match your validation rules.

		``max_length``
		If the field is some sort of text field, then the ``max_length``option can be
		``maxlength``
Copy link Contributor HeahDudeDec 18, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Thanks for opening this PR! This change is legit, but I think you should also replace`option` by`html attribute` for both this one and`required` above. since this does not use the options at all, but the`attr` option, btw`max_length` option has been deprecated in 2.5.
		If the field is some sort of text field, then the ``maxlength``html attribute can be
		guessed from the validation constraints (if ``Length`` or ``Range`` is used) or
		from the Doctrine metadata (via the field's length).

Expand Down