Test failure unrelated to this PR:https://travis-ci.org/symfony/symfony-docs/builds/184129616#L215

Assumingsymfony/symfony#20863 is merged as-is, documentation is up-to-date. Refactored the adapter pool docs to move theminto separate files (they haven't otherwise been edited aside from a link to DSN in the Redis adapter and correcting the spacing in theindex definition of the cache files), as the document became very, very long with thedetailed Memcached adapter docs added.

Great work! Instead of listing the options, I wonder if we shouldn't link to the php doc. If we could expand to the same level the redis section, it could be great to have them on parity.

Regarding Redis: I'll give that a look and update it in-line with Memcached adapter; sure.

As for the Memcached options, I'm split on this. The original copy didn't have options, and later they were added for a few reasons. First, the PHP manual includes invalid options, likecache_lookups (and more), which will cause a deprecation exception to be thrown by the extension. Second, the PHP manual is missing options, likerandomize_replica_read (and more). Third, the PHP manual doesn't do a great job of making it obvious what are option names and what are option values. Lastly, I tried to provide better descriptions, especially where a description was completely absent, but also where it was simply ambiguous or badly written.

Which is what led to the inclusion of options in the Symfony docs.

@nicolas-grekas Given the above, do youstill think we shouldjust link to the PHP manual? It should be noted that Istill do link to the manual as the last line of the documentation.

Reasonable :) let's see what the docs core team thinks about it, maybe there is some existing practice on the topic.
I may have missed it, but we should tell that v2.2 or higher is required btw!

Good catch (re version requirement). Will add.

@javiereguiluz Thanks for taking a look and reviewing this PR; I won't have time to update this PR until the coming weekend. You can expect me to address any comments you made, as well as expand the Redis section. I'll be sure to submit something before the end of the weekend, and then this should likely be merged ASAP, as all related PRs have been finalized and submitted into the Symfony codebase already. I'll let you and@nicolas-grekas know when this needs a final review. Thanks!

@nicolas-grekas Finished the section pertaining to Redis connection options (seethe platform.sh build). Feel free to advise me if you require additional changes.

@javiereguiluz Did some rebasing to clean this up a bit; let me know if I should squash or otherwise edit the commit history prior to the PR's merger.

This should be ready!

Doc what the default "persistent_id" is when only persistent is set? (I don't remember myself)

@nicolas-grekas Didn't look like that was the case when I gave it a once-over

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Traits/RedisTrait.php#L105

Please correct me if I am wrong and should add something aboutpersistend_id only applying whenpersistent is enabled, but it doesn't look like that is the case to me.

Erm, nevermind, misread your comment. The defaultisnull.

That said, the behavior looks different for\Redis and\Predis\Client: with\Redis it will enable persistent connections if eitherpersistent orpersistent_id is set, but withPredis\Client it just blindly passes the parameters. Does that client behave similarly?

Is this good to go, or do I need to do anything prior to merge?

@robfrawley Can you resolve conflicts here?

@xabbuh rebased

@xabbuh fixes pushed

👍

Status: Reviewed

@javiereguiluz@xabbuh Anything else you guys want me to do for this PR? This should likely be merged sooner than later, as (aside from the general cleanup and expansion of adapter docs) it provides the initial documentation for the Memcached feature, which has been live onmaster for over a month.

Additionally, as this PR reorganizes and moves all the adapter docs into their own pages, it will continue to have merge conflicts when anyone so much astouches the adapter docs, and I'd appreciate not having to rebase this PR over and over. ;-)

All the best.

👍 Let's merge this.

@javiereguiluz Anything else from your side?

@xabbuh nothing else from me ... just thanking@robfrawley again for his amazing work here!

Thanks for the reviews as well, guys. Symfony is absolutely the best community to be involved in, and you guys do an amazing job maintaining the respective aspects of the project you contribute to@nicolas-grekas,@javiereguiluz, and@xabbuh!

Thank you@robfrawley.