Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Validator] Fixed wrong inheritance information#7249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@peterrehm Shouldn't this be merged into the |
Yes, my bad. |
👍 LGTM Status: Reviewed |
Thank you@peterrehm. |
xabbuh added a commit that referenced this pull requestDec 25, 2016
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#7249).Discussion----------[Validator] Fixed wrong inheritance informationThere is wrong information about the inheritance of validation groups.I have tested it extensively and some findings are documented here:symfony/symfony#20857I also asked Bernhard about what the intended behavior is, but I assumeas I have documented it now was the original expected behaviour.Commits-------49dfdf4 Fixed wrong inheritance information
xabbuh added a commit that referenced this pull requestJan 10, 2017
This PR was merged into the 2.7 branch.Discussion----------[Validation] Revert#7249This reverts commit6c3ff5e sincedue tosymfony/symfony#21183 the logic is meanwhile changed.Commits-------3250ed4 Revert "Fixed wrong inheritance information"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is wrong information about the inheritance of validation groups.
I have tested it extensively and some findings are documented here:symfony/symfony#20857
I also asked Bernhard about what the intended behavior is, but I assume
as I have documented it now was the original expected behaviour.