Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[PHPUnitBridge] Fix versionadded notes#7211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I was reading the docs and noted that those features were marked as present only from Symfony 3.1/2. The reality is that the version that includes that stuff is the bridge's, which is backward compatible!So, as an example, I can use the bridge v3.2 on my Symfony 2.8 app.I think it should be helpfull to specify that more clearly.
javiereguiluz approved these changesDec 3, 2016
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 I like this improvement.
I just have a question: is this change enough to understand that this refers to the component version instead of the Symfony version?
If you agree, maybe we can replace... in version 3.1. by... in the 3.1 version of this component. ?
Following javiereguiluz suggestions
ContributorAuthor
Jean85 commentedDec 5, 2016
I completly agree! Also: should this stuff be backported to the 3.2 branch? Or to an older one? |
components/phpunit_bridge.rst Outdated
| The ability to disable the deprecation helper was introduced inSymfony | ||
| 3.1. | ||
| The ability to disable the deprecation helper was introduced inthe 3.1 | ||
| version of this component |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should IMO keep the dot at the end of all sentences.
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done!
Member
xabbuh commentedDec 8, 2016
👍 Status: Reviewed |
Microfix: restoring punctuation.
Member
xabbuh commentedDec 12, 2016
Thank you@Jean85. |
xabbuh added a commit that referenced this pull requestDec 12, 2016
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes#7211).Discussion----------[PHPUnitBridge] Fix versionadded notesI was reading the docs and noted that those features were marked as present only from Symfony 3.1/2. The reality is that the version that includes that stuff is the bridge's, which is backward compatible!So, as an example, I can use the bridge v3.2 on my Symfony 2.8 app.I think it should be helpfull to specify that more clearly.Commits-------189b2a5 [PHPUnitBridge] Fix versionadded notes
xabbuh added a commit that referenced this pull requestDec 12, 2016
This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes#7211).Discussion----------[PHPUnitBridge] Fix versionadded notesI was reading the docs and noted that those features were marked as present only from Symfony 3.1/2. The reality is that the version that includes that stuff is the bridge's, which is backward compatible!So, as an example, I can use the bridge v3.2 on my Symfony 2.8 app.I think it should be helpfull to specify that more clearly.Commits-------59e3f95 [PHPUnitBridge] Fix versionadded notes
xabbuh pushed a commit that referenced this pull requestDec 13, 2016
Due to my own screw-up, I copy pasted the same text in all the changes from my previous PR,#7211, as it's clearly visible from the compare view:https://github.com/symfony/symfony-docs/pull/7211/filesThis PR fixes the issue, reverting back the part of text that should be unaffected by my intended changes.
xabbuh added a commit that referenced this pull requestDec 13, 2016
This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes#7246).Discussion----------[PHPUnitBridge] Fix copy/paste errorDue to my own screw-up, I copy pasted the same text in all the changes from my previous PR,#7211, as it's clearly visible from the compare view:https://github.com/symfony/symfony-docs/pull/7211/filesThis PR fixes the issue, reverting back the part of text that should be unaffected by my intended changes.Commits-------97ec0c6 [PHPUnitBridge] Fix copy/paste error
xabbuh pushed a commit that referenced this pull requestDec 13, 2016
Due to my own screw-up, I copy pasted the same text in all the changes from my previous PR,#7211, as it's clearly visible from the compare view:https://github.com/symfony/symfony-docs/pull/7211/filesThis PR fixes the issue, reverting back the part of text that should be unaffected by my intended changes.
xabbuh added a commit that referenced this pull requestDec 13, 2016
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes#7246).Discussion----------[PHPUnitBridge] Fix copy/paste errorDue to my own screw-up, I copy pasted the same text in all the changes from my previous PR,#7211, as it's clearly visible from the compare view:https://github.com/symfony/symfony-docs/pull/7211/filesThis PR fixes the issue, reverting back the part of text that should be unaffected by my intended changes.Commits-------a4241bc [PHPUnitBridge] Fix copy/paste error
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading the docs and noted that those features were marked as present only from Symfony 3.1/2. The reality is that the version that includes that stuff is the bridge's, which is backward compatible!
So, as an example, I can use the bridge v3.2 on my Symfony 2.8 app.
I think it should be helpfull to specify that more clearly.