Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[#6947] some minor tweaks#7075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:masterfromxabbuh:pr-6947
Nov 5, 2016
Merged

[#6947] some minor tweaks#7075

xabbuh merged 1 commit intosymfony:masterfromxabbuh:pr-6947
Nov 5, 2016

Conversation

@xabbuh
Copy link
Member

No description provided.

@wouterj
Copy link
Member

👍
status: reviewed

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

each cacheditems. Each tag is a plain string identifier that you can use at any
time to trigger the removal of all items thathad this tag attached to them.
each cacheditem. Each tag is a plain string identifier that you can use at any
time to trigger the removal of all items thathave this tag attached to them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

all items that have this tag attached to them. ->all items associated with this tag. ?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

done

$cache->invalidateTags(array('tag_1', 'tag_3'));

// if you know the cache key, you can of course delete directly
// if you know the cache key, you can of course deletethe itemdirectly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removeof course in this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Because terms like "of course", "very easy", "just...", "easily", "simply", etc. are patronizing and most of the times, redundant.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree, updated here too.

@javiereguiluz
Copy link
Member

Great! Ready to be merged. Thanks@xabbuh.

@xabbuhxabbuh merged commitf865f93 intosymfony:masterNov 5, 2016
xabbuh added a commit that referenced this pull requestNov 5, 2016
This PR was merged into the master branch.Discussion----------[#6947] some minor tweaksCommits-------f865f93 [#6947] some minor tweaks
@xabbuhxabbuh deleted the pr-6947 branchNovember 5, 2016 11:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@wouterjwouterjwouterj left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@wouterj@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp