Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[DoctrineBridge] Document the newentityClass option#7057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| **type**: ``string`` **default**: ``null`` | ||
| The fully-qualified class name (FQCN) of the entity to get the repository used for making the query to determine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't like this sentence very much. Any hint on how to rephrase it better ? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe
The fully-qualified class name (FQCN) of the entity for which to get the repository used to determine the uniqueness
? Or just keep it as is for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here is a proposal that says exactly the same but in a different order:
By default, the query performed to ensure the uniqueness uses the repository ofthe current class instance. However, in some cases, such as when using Doctrineinheritance mapping, you need to execute the query in a different repository.Use this option to define the fully-qualified class name (FQCN) of the Doctrineentity associated with the repository you want to use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@javiereguiluz : Perfect ! I'll update this PR in the minute. Thank you 🎉
fc063f2 to8e4e47aCompare…ed by the UniqueEntity validator (ogizanagi)This PR was merged into the 3.2-dev branch.Discussion----------[DoctrineBridge] Add a way to select the repository used by the UniqueEntity validator| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#12573,#4087,#12977| License | MIT| Doc PR |symfony/symfony-docs#7057This is a cherry pick of#12977 on ~~2.8~~ 3.2 branch, as it is clearly a new feature, even if it was primary introduced in order to fix an inappropriate behavior that might be considered as a bug.Commits-------00d5459 [Doctrine] [Bridge] Add a way to select the repository used by the UniqueEntity validator
…ed by the UniqueEntity validator (ogizanagi)This PR was merged into the 3.2-dev branch.Discussion----------[DoctrineBridge] Add a way to select the repository used by the UniqueEntity validator| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #12573, #4087, #12977| License | MIT| Doc PR |symfony/symfony-docs#7057This is a cherry pick of #12977 on ~~2.8~~ 3.2 branch, as it is clearly a new feature, even if it was primary introduced in order to fix an inappropriate behavior that might be considered as a bug.Commits-------00d5459 [Doctrine] [Bridge] Add a way to select the repository used by the UniqueEntity validator
8e4e47a toa9c2fc2ComparePR updated according to@javiereguiluz 's suggestion. The PR on the code repository has been merged too. |
entityClass optionentityClass option👍 |
👍 |
…(ogizanagi)This PR was merged into the master branch.Discussion----------[DoctrineBridge] Document the new `entityClass` optionWaiting forsymfony/symfony#15002 to be merged.Commits-------a9c2fc2 [DoctrineBridge] Document the new `entityClass` option
Thanks@ogizanagi! Prefect PR! I've moved the versionadded directives directly after the title, as this is consistent with the versionadded directives in form types options. |
Waiting forsymfony/symfony#15002 to be merged.