Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Serializer] Move the see also block in the Learn More section#7043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mickaelandrieu approved these changesOct 6, 2016
👍 Status: Reviewed |
👍 |
Thank you Kévin. |
xabbuh added a commit that referenced this pull requestOct 14, 2016
…ction (dunglas)This PR was merged into the 2.7 branch.Discussion----------[Serializer] Move the see also block in the Learn More sectionCommits-------e1ca7bd [Serializer] Move the see also block in the Learn More section
smnandre added a commit to smnandre/symfony-docs that referenced this pull requestSep 28, 2025
Removed mention of JMS serializer as an alternative to Symfony Serializer.It was pushed at the bottom of page insymfony#7043Reintroduced insymfony#17783 during the big merge of the serializer docs (i guess because new structure had no more a natural good place in the end of the page)---To me, it does not feel necessary, and I'm betting create more confusion in readers mind that really helps anyone..But my main point will be "why is this not done on other packages doc pages?" ... if we need to promote alternative, I can think of a few other Symfony packages where that kind of mention could be legit...Well just a minor thing passing by :)So I suggest we simply remove this mention.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.