Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add empty parentheses to method names#7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
bocharsky-bw wants to merge1 commit intosymfony:masterfrombocharsky-bw:patch-5

Conversation

@bocharsky-bw
Copy link
Contributor

@bocharsky-bwbocharsky-bw commentedSep 29, 2016•
edited
Loading

Method name is clearer with empty parentheses at the end

Bundle Controller Class Method Name
============= ================== ==============
``AppBundle`` ``BlogController`` ``showAction``
``AppBundle`` ``BlogController`` ``showAction()``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You now have to expand the table= lines.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, sorry, missed it. Expanded

@wouterj
Copy link
Member

👍
status: reviewed

Thanks!

@javiereguiluz
Copy link
Member

A big 👍 from me (and I think there are other places where we could do this change). Thanks@bocharsky-bw!

@wouterj
Copy link
Member

Thanks again! (fyi, this PR is closed as the commit has been merged in 2.7, the lowest still maintained branch)

wouterj added a commit that referenced this pull requestSep 29, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#7016).Discussion----------Add empty parentheses to method namesMethod name is clearer with empty parentheses at the endCommits-------04c44e9 Add empty parentheses to the method name
@bocharsky-bw
Copy link
ContributorAuthor

You're welcome!
@javiereguiluz I'll look closely at it and will send more PRs if I found something.
@wouterj Should I send further PRs to the2.7 branch instead ofmaster?

@bocharsky-bwbocharsky-bw deleted the patch-5 branchSeptember 29, 2016 10:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bocharsky-bw@wouterj@javiereguiluz@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp