Update page_creation.rst#7012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

paolovas wants to merge1 commit intosymfony:3.1frompaolovas:patch-1

Closed

Update page_creation.rst#7012

paolovas wants to merge1 commit intosymfony:3.1frompaolovas:patch-1

Conversation

Copy link

paolovas commentedSep 26, 2016

missing <?php

Update page_creation.rst

a851c8c

carsonbot added the Status: Needs Review label

Sep 26, 2016

Copy link

Author

paolovas commentedSep 26, 2016

missing <?php

Copy link

Member

javiereguiluz commentedSep 28, 2016

@paolovas thanks for reporting this. You are right and those opening tags are missing.

However, instead of a "bug", this is considered a "feature" of the docs. It was decided a while ago to remove all the opening and closing PHP tags in the examples of the docs. In the past we've receivedsome issues andsome pull requests similar to this one and they were always rejected for not considering those tags strictly necessary for the code snippets shown in the docs.

The good news is that we addedthis feature to Symfony so you get an error message when the opening tag is missing.

For these reasons, I'm closing this pull request as "won't fix". I'm sorry.