Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Patch based 2.7#6985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Patch based 2.7#6985
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The old sentence was confusing. This one works better.
Its better to use e.g. here cause that is just an example. Doesn't always going to be in that path.
The word 'or' is clear. / not so much.
Titles use caps.Unnecessary sentence.
bundles/installation.rst Outdated
| ..code-block::bash | ||
| $app/console config:dump-reference AsseticBundle | ||
| $bin/console config:dump-reference AsseticBundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This does only apply to Symfony >= 3.0.
| service as explained in `Services & Configuration`_. This, of course, will only | ||
| work if the type is referred to by its alias rather than being instantiated, | ||
| e.g.:: | ||
| Form types are referred to by their fully-qualified class name:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is only true for Symfony >= 2.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But we may want to remove this paragraph entirely for the 2.7 docs and only talk about form type extensions.
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@franciscocorrales I left some minor comments that should be addressed. But overall I like your suggestions.
This does only apply to Symfony >= 3.0.
javiereguiluz commentedFeb 14, 2017
@franciscocorrales thanks for contributing these improvements. The PR stalled and has conflicts, so I'm finishing it in#7490. I reused your original commits, so you'll get full credit for your work. Thanks! |
…javiereguiluz)This PR was merged into the 2.7 branch.Discussion----------Minor fixes about bundle overriddingThis finishes#6985.Commits-------c9a52ae Added the changes suggested by reviewersd5cd8d0 Reworded the section about form overridding600d302 Update installation.rst62bfc21 Update prepend_extension.rst2f837d6 Update override.rst3433e50 Update installation.rstf684bdd Update inheritance.rst
Doc changes on 2.7